[Impeller] Improved documentation of the gaussian blur. #47283
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
gaaclarke
force-pushed
the
gaussian-doc
branch
from
9e67b15 to
94afdc5
Compare
chinmaygarde
changed the title
| Point(0, 1), blur_style, tile_mode, | ||
| true, sigma_x); | ||
| std::shared_ptr<FilterContents> x_blur = MakeDirectionalGaussianBlur( | ||
| /*input=*/input, |
There was a problem hiding this comment.
Thanks. I hate how the default .clang-format mushes the args together.
Drive by comment: Is there an IDE plugin that figures this out (and keeps them in sync across arg renames)? I like to add empty comments just to things aligned.
There was a problem hiding this comment.
The big thing for me was being able to see what true and {} is. There is the clang_tidy check bugprone-argument-comment which I swear I turned on at some point. That makes sure the comments match the parameters.
I've never seen an IDE plugin that adds the comments. It should be possible with vscode.
There was a problem hiding this comment.
I've never seen an IDE plugin that adds the comments. It should be possible with vscode.
Yeah, it does seem like toil that should been automated away by this point.
| /// | | | | +----+ | ||
| /// | | | | 87x102 | ||
| /// +-------------+ +-----+ | ||
| /// 586x678 97x678 |
There was a problem hiding this comment.
Haha, nice. Love this graphic. :)
There was a problem hiding this comment.
dude, emacs "artist mode"
There was a problem hiding this comment.
gaaclarke
force-pushed
the
gaussian-doc
branch
from
94afdc5 to
f1606aa
Compare
…137347) flutter/engine@0a6253d...d8132d5 2023-10-26 [email protected] [Impeller] Improved documentation of the gaussian blur. (flutter/engine#47283) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
Just trying to capture some of my thoughts as I look into some blur bugs.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.