Move flutter.js into the engine. #47240
Conversation
This will allow us to add tooling to do some bundling/minifying of flutter.js, which should make this more scalable/extensible long-term.
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
LGTM!
Do you have a link to the framework side of the change, or are you waiting for this to land?
There was a problem hiding this comment.
In order to integrate with more tooling in the future, would it be easier that this file lived in engine/js/flutter_js or similar? (I know little about GN).
((I guess that if needed it could be moved later, as long as its output ends up in the same directory?))
There was a problem hiding this comment.
The files themselves can be anywhere in the source tree, so that doesn't really matter to gn. I'm not sure where you are suggesting this should go in the tree though, do you mean inside the actual src/flutter/lib/web_ui/lib/src/engine directory somewhere? I'd like to avoid having non-dart files in that part of the source tree, I think.
Draft for consuming this is here: flutter/flutter#137113 |
eyebrowsoffire
added
the
autosubmit
…ions) (#137649) Manual roll requested by [email protected] flutter/engine@39be0fc...406b7d7 2023-10-31 [email protected] Roll Dart SDK from eecb650a0fb9 to 99fa0283f9d7 (1 revision) (flutter/engine#47526) 2023-10-31 [email protected] Roll Skia from 998e19071734 to aaa225e0cc6d (1 revision) (flutter/engine#47524) 2023-10-31 [email protected] Roll Skia from cc751f5d50ea to 998e19071734 (1 revision) (flutter/engine#47522) 2023-10-31 [email protected] Roll Skia from 2f7e5dbb8521 to cc751f5d50ea (1 revision) (flutter/engine#47519) 2023-10-31 [email protected] Move flutter.js into the engine. (flutter/engine#47240) 2023-10-31 [email protected] Roll Skia from b3360479118f to 2f7e5dbb8521 (1 revision) (flutter/engine#47517) 2023-10-31 [email protected] [Impeller] Do not return a null Contents if a Paint's blur filter yields an empty coverage rect (flutter/engine#47496) 2023-10-31 [email protected] Roll Dart SDK from 776fad25647a to eecb650a0fb9 (1 revision) (flutter/engine#47514) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DartPad was using these :) dart-lang/dart-pad#2718; specifically, We use it with DDC to support modular compilation in dartpad - just compiling the user's source and using pre-built JS of the framework and related libraries (https://github.com/dart-lang/dart-pad/blob/main/pkgs/dart_services/tool/grind.dart#L247). Did this have a maintenance cost? Can it be restored? Can or should we (dartpad) build this kernel file ourselves? |
3 participants
This will allow us to add tooling to do some bundling/minifying of
flutter.js, which should make this more scalable/extensible long-term.Also, this removes a few redundant build rules that produce artifacts that the flutter tool doesn't use anymore.