This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Allow 3D scenes to render when MSAA is not supported. #47217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Also needs #47218 to actually render the playgrounds. |
Contributor
|
You may need to click the update branch button |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 1, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 1, 2023
…137651) flutter/engine@406b7d7...db06c2e 2023-10-31 [email protected] Roll Fuchsia Mac SDK from rg_Ici1tgAVF93cn9... to x2NzYMNhyodIwDl0I... (flutter/engine#47528) 2023-10-31 [email protected] [Impeller] updated ios benchmark link (flutter/engine#47515) 2023-10-31 [email protected] Made clang tidy use arm64 if on an arm64 mac. (flutter/engine#47494) 2023-10-31 [email protected] [Impeller] Allow 3D scenes to render when MSAA is not supported. (flutter/engine#47217) 2023-10-31 [email protected] Surgically remove `.*dither.*` from the Engine (flutter/engine#46750) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from rg_Ici1tgAVF to x2NzYMNhyodI If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, Impeller Scene would render nothing on the GLES backend when used through Aiks.