This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Vk query cleanups. #47208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
changed the title
jonahwilliams
commented
Oct 23, 2023
|
|
||
| void GPUTracerVK::MarkFrameStart() { | ||
| FML_DCHECK(!in_frame_); | ||
| FML_CHECK(!in_frame_); |
Contributor
Author
There was a problem hiding this comment.
this should be changed back to a DCHECK
jonahwilliams
commented
Oct 23, 2023
| private: | ||
| friend struct GPUProbe; | ||
|
|
||
| static const constexpr size_t kTraceStatesSize = 32u; |
Contributor
Author
There was a problem hiding this comment.
I increased the size of the number of pending queries because on very slow apps I observed that we would get backed up more than the previous 16.
Contributor
Author
|
These tests are failing sometimes because I'm relying on the dtor to call this final query method, but my latch is invoked by the closure that runs first. |
matanlurey
approved these changes
Oct 23, 2023
| bool enabled_ = false; | ||
| }; | ||
|
|
||
| struct GPUProbe { |
Contributor
There was a problem hiding this comment.
Given this behaves more class-like, I'd just make it a class
(https://google.github.io/styleguide/cppguide.html#Structs_vs._Classes)
Contributor
Author
There was a problem hiding this comment.
Good call. It did start out more struct like...
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 23, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 23, 2023
…137100) flutter/engine@e89f042...abeab89 2023-10-23 [email protected] [Impeller] Added tests to assert empty saveLayer behaviors. (flutter/engine#47138) 2023-10-23 [email protected] Roll Skia from d534571c4bc3 to 73e9879f06e7 (1 revision) (flutter/engine#47233) 2023-10-23 [email protected] Add missing headers to the fml source_set. (flutter/engine#47232) 2023-10-23 [email protected] [Impeller] Vk query cleanups. (flutter/engine#47208) 2023-10-23 [email protected] Roll Skia from 4976279e4441 to d534571c4bc3 (1 revision) (flutter/engine#47231) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
Use RAII to more accurately capture cmd buffer start/end, with additional protections for early frame ending. This also allows us to capture the execution time of the final cmd buffer, which should fix flutter/flutter#136971
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use RAII to more accurately capture cmd buffer start/end, with additional protections for early frame ending. This also allows us to capture the execution time of the final cmd buffer, which should fix flutter/flutter#136971