Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@chinmaygarde
Copy link
Member

No description provided.

@chinmaygarde
Copy link
Member Author

The bit about multiple simultaneous reactions being safe will only be true after @jason-simmons s patch :)

@chinmaygarde chinmaygarde self-assigned this Oct 18, 2023
@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 18, 2023
@auto-submit auto-submit bot merged commit 7377006 into flutter:main Oct 18, 2023
@chinmaygarde chinmaygarde deleted the doc_reactor branch October 18, 2023 22:21
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 19, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 19, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 19, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 19, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 19, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 19, 2023
…136872)

flutter/engine@8d51b64...d0d7b4d

2023-10-19 [email protected] Revert "[web] Ensure handled key event is not propagated to IME" (flutter/engine#47086)
2023-10-19 [email protected] Roll Fuchsia Linux SDK from 2HSBpWikGWvPJlHOP... to Z2mOZ5cuPJWvKn22P... (flutter/engine#47094)
2023-10-19 [email protected] Roll Skia from 64c5de6663a4 to 62acc1e162cc (1 revision) (flutter/engine#47093)
2023-10-19 [email protected] Roll Dart SDK from eb3fb9a13e16 to 1b425a25a6dd (1 revision) (flutter/engine#47092)
2023-10-19 [email protected] Roll Skia from 85971b25cf4b to 64c5de6663a4 (2 revisions) (flutter/engine#47091)
2023-10-19 [email protected] Roll Fuchsia Mac SDK from PxJM5ivbnbYoVkqBg... to 0hLSNJ_DCTzRvTVJe... (flutter/engine#47090)
2023-10-19 [email protected] Roll Dart SDK from d9b1e60fe442 to eb3fb9a13e16 (1 revision) (flutter/engine#47084)
2023-10-18 [email protected] Update buildroot to ab76ccba2ca4ce4. (flutter/engine#47078)
2023-10-18 [email protected] migrate const_finder to use the implementation from package:kernel (flutter/engine#47077)
2023-10-18 [email protected] Roll Skia from d561b276b5d9 to 85971b25cf4b (1 revision) (flutter/engine#47076)
2023-10-18 [email protected] [Impeller] Guard execution of ReactorGLES operations with a mutex (flutter/engine#47068)
2023-10-18 [email protected] [Impeller] Document ReactorGLES. (flutter/engine#47070)
2023-10-18 [email protected] [web] Ensure handled key event is not propagated to IME (flutter/engine#46829)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 2HSBpWikGWvP to Z2mOZ5cuPJWv
  fuchsia/sdk/core/mac-amd64 from PxJM5ivbnbYo to 0hLSNJ_DCTzR

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants