This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add missing source file #47046
Merged
Add missing source file #47046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 18, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 18, 2023
…136829) flutter/engine@b778a07...0eff5d1 2023-10-18 [email protected] Roll Skia from 5857f5f05b35 to b8c989df901a (5 revisions) (flutter/engine#47060) 2023-10-18 [email protected] Roll Fuchsia Linux SDK from OudOcFarQhQQzKDBx... to 2HSBpWikGWvPJlHOP... (flutter/engine#47059) 2023-10-18 [email protected] Roll Skia from a52d2a9e2b01 to 5857f5f05b35 (1 revision) (flutter/engine#47057) 2023-10-18 [email protected] Add missing source file (flutter/engine#47046) 2023-10-18 [email protected] Roll Fuchsia Mac SDK from Kp2wNpzRlAtbME0R4... to PxJM5ivbnbYoVkqBg... (flutter/engine#47056) 2023-10-18 [email protected] Roll Skia from 5172e904def7 to a52d2a9e2b01 (2 revisions) (flutter/engine#47055) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from OudOcFarQhQQ to 2HSBpWikGWvP fuchsia/sdk/core/mac-amd64 from Kp2wNpzRlAtb to PxJM5ivbnbYo If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
Maybe I'm missing something here. It seems like we include this file below: https://github.com/flutter/engine/blob/c9c9684e03a3e1f745cbd4f8de762f42aa01ae77/shell/platform/embedder/pixel_formats.cc#L5 But it isn't mentioned in the gn file. Not sure how it is actually working today.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe I'm missing something here. It seems like we include this file below:
engine/shell/platform/embedder/pixel_formats.cc
Line 5 in c9c9684
But it isn't mentioned in the gn file. Not sure how it is actually working today.
Pre-launch Checklist
///).