This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland: Remove the frontend server wrapper #47010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
build/dart/rules.gni
Outdated
| "--depfile", | ||
| rebase_path(snapshot_depfile), | ||
| "--output-dill", | ||
| rebase_path(invoker.kernel_output), |
Member
There was a problem hiding this comment.
Change this to rebase_path(invoker.kernel_output, root_build_dir)
This will make Dart generate a depfile containing a relative path to the target. Without that, GN will not recognize the target in the depfile and will think that this target needs to be rebuilt on every build.
zanderso
force-pushed
the
reland-rm-ffes
branch
from
38b9a1a to
c9380b8
Compare
jason-simmons
approved these changes
Oct 17, 2023
Contributor
|
Once cl/574272225 is submitted, this will be ready to land. |
CaseyHillers
approved these changes
Oct 18, 2023
zanderso
force-pushed
the
reland-rm-ffes
branch
from
c9380b8 to
19200cb
Compare
zanderso
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 18, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 18, 2023
…136844) flutter/engine@6caee32...b67edb0 2023-10-18 [email protected] [iOS TextInputPlugin] adjust the markedTextRange when replacing text. (flutter/engine#46603) 2023-10-18 [email protected] Reland: Remove the frontend server wrapper (flutter/engine#47010) 2023-10-18 [email protected] Roll Skia from 9880c4006735 to ef0e93524e7d (1 revision) (flutter/engine#47069) 2023-10-18 [email protected] Roll Skia from 523f04f1a898 to 9880c4006735 (1 revision) (flutter/engine#47067) 2023-10-18 [email protected] Roll Skia from ccd07c6f5042 to 523f04f1a898 (1 revision) (flutter/engine#47065) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relands #46440 with #46842