Move the secondary build tree into the engine. #46989
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
The only change past the moving of the files into the repository was to not pylint the build directory since it now contains vendored folders that I can't fix the formatting of. I can setup more specialized lint rules later. |
| @@ -0,0 +1,1205 @@ | |||
| # Copyright 2014 The Chromium Authors. All rights reserved. | |||
There was a problem hiding this comment.
The targets in this file appear to be unused, and I can't find the sources they refer to. I think this file might be dead code?
There was a problem hiding this comment.
Almost certain it is. I didn't want to do cleanups in this patch since there may be platforms I am missing. This is just a pure moving of the directory.
DEPS
Outdated
|
|
||
| deps = { | ||
| 'src': 'https://github.com/flutter/buildroot.git' + '@' + '1d2965f9b0f784abea8ddbeb54827afa9ed196b9', | ||
| 'src': 'https://github.com/chinmaygarde/flutter_buildroot.git' + '@' + 'd9c9c9fa64c3a9d1098eff61f71c206722980a62', |
There was a problem hiding this comment.
I am guessing you're updating this before submitting?
There was a problem hiding this comment.
Yeah. Just wanted to get the presubs going.
Part of flutter/flutter#67373. Pulled into the engine in flutter/engine#46989.
Now, both the DEPS and the custom GN rules for them are in the same repo and won't need a buildroot sibling patch + roll. Part of flutter/flutter#67373. Pending landing of the buildroot patch in flutter/buildroot#781 (the DEPS will be updated before landing and after the presubs pass).
chinmaygarde
force-pushed
the
mv_second
branch
from
969cbfe to
81c1a8e
Compare
chinmaygarde
added
the
autosubmit
…136739) flutter/engine@3ecbe92...62a90a9 2023-10-17 [email protected] [Impeller] added trace statements for colorsources (flutter/engine#47007) 2023-10-17 [email protected] Move the secondary build tree into the engine. (flutter/engine#46989) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Now, both the DEPS and the custom GN rules for them are in the same repo and won't need a buildroot sibling patch + roll. Part of flutter/flutter#67373. Pending landing of the buildroot patch in flutter/buildroot#781 (the DEPS will be updated before landing and after the presubs pass).
4 participants
Now, both the DEPS and the custom GN rules for them are in the same repo and won't need a buildroot sibling patch + roll.
Part of flutter/flutter#67373. Pending landing of the buildroot patch in flutter/buildroot#781 (the DEPS will be updated before landing and after the presubs pass).