This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Allow Image backed platform view rendering target on Android >= 29 again #46958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johnmccutchan
commented
Oct 16, 2023
johnmccutchan
commented
- Refactor the fence waiting code to only wait on Android >= 33.
- Log a warning message once per image rendering target on Android >= 29 && < 33.
- Add a simple unit test of ImageReaderPlatformViewRenderTargets.
jonahwilliams
approved these changes
Oct 16, 2023
| @@ -0,0 +1,101 @@ | |||
| package io.flutter.plugin.platform; | |||
johnmccutchan
added
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/46958, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
- Refactor the fence waiting code to only wait on Android >= 33. - Log a warning message once per image rendering target on Android >= 29 && < 33. - Add a simple unit test of ImageReaderPlatformViewRenderTargets.
johnmccutchan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 16, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 16, 2023
…136675) flutter/engine@83224dc...2d55e29 2023-10-16 [email protected] [macOS] FlutterMutatorView should clip to bounds (flutter/engine#46463) 2023-10-16 [email protected] Roll Skia from 0e5207fb4971 to 85c8dca08cbe (1 revision) (flutter/engine#46964) 2023-10-16 [email protected] Allow Image backed platform view rendering target on Android >= 29 again (flutter/engine#46958) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
…ain (#46958) - Refactor the fence waiting code to only wait on Android >= 33. - Log a warning message once per image rendering target on Android >= 29 && < 33. - Add a simple unit test of ImageReaderPlatformViewRenderTargets.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.