[Impeller] Vulkan GPU tracer cleanups #46915
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| const auto device_holder = strong_context->GetDeviceHolder(); | ||
| if (!buffer->SubmitCommands([&, last_query, | ||
| device_holder](CommandBuffer::Status status) { | ||
| auto strong_context = context_.lock(); |
There was a problem hiding this comment.
We dont need this here, this might be causing shutdown issues since this may keep the context alive longer than it should
| "FrameTimeMS", gpu_ms); | ||
| } | ||
| })) { | ||
| if (!buffer->SubmitCommands()) { |
| if (!buffer->SubmitCommands()) { | ||
| VALIDATION_LOG << "GPUTracerVK failed to record frame end time."; | ||
| } | ||
| VALIDATION_LOG << "GPUTracerVK failed to record frame end time."; |
There was a problem hiding this comment.
optional minor readability nit: Since the body of the if follows a long closure argument to SubmitCommands it was hard for me to tell whether it was part of the closure, part of the if-body, or after the if-body. Maybe consider assigning the result of SubmitCommands to a bool variable, and then branch on the bool variable.
jonahwilliams
added
the
autosubmit
…136589) flutter/engine@73acf62...015e352 2023-10-14 [email protected] [Impeller] Vulkan GPU tracer cleanups (flutter/engine#46915) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cleanups that seem to reduce occurance of SIGBUS crash, which It turns out I did not in fact fix.
2 participants
Cleanups that seem to reduce occurance of SIGBUS crash, which It turns out I did not in fact fix.