This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Make HotRestartCacheHandler standalone #46906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
approved these changes
Oct 20, 2023
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
Small nits that I think will help with readability of the code (or maybe it's because it's a little bit late and my brain is collapsing 🧠💨)
lib/web_ui/lib/src/engine/view_embedder/embedding_strategy/embedding_strategy.dart
Outdated
Show resolved
Hide resolved
...eb_ui/lib/src/engine/view_embedder/embedding_strategy/custom_element_embedding_strategy.dart
Outdated
Show resolved
Hide resolved
lib/web_ui/lib/src/engine/view_embedder/embedding_strategy/full_page_embedding_strategy.dart
Outdated
Show resolved
Hide resolved
lib/web_ui/lib/src/engine/view_embedder/hot_restart_cache_handler.dart
Outdated
Show resolved
Hide resolved
mdebbar
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 20, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 20, 2023
…136973) flutter/engine@21b5c37...d46933e 2023-10-20 [email protected] Roll Skia from 461218cee44c to de628929015d (1 revision) (flutter/engine#47161) 2023-10-20 [email protected] [web] Make HotRestartCacheHandler standalone (flutter/engine#46906) 2023-10-20 [email protected] [web] Attach pointer event listeners in the bubble phase (flutter/engine#47121) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
- `EmbeddingStrategy` shouldn't own the creation of `HotRestartCacheHandler`. - Simplify `HotRestartCacheHandler`'s JS-interop by using a `JSArray` directly instead of going through a Dart `List`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EmbeddingStrategyshouldn't own the creation ofHotRestartCacheHandler.HotRestartCacheHandler's JS-interop by using aJSArraydirectly instead of going through a DartList.