[web] - Fix inputmode on Android Firefox
#46901
Conversation
| } else if (browserEngine == BrowserEngine.webkit) { | ||
| strategy = SafariDesktopTextEditingStrategy(textEditing); | ||
| } else if (browserEngine == BrowserEngine.blink && | ||
| } else if ((browserEngine == BrowserEngine.blink || browserEngine == BrowserEngine.firefox) && |
There was a problem hiding this comment.
Is there a contextual reason why we have to specify a browser engine as well as the OS when we're trying to select for a mobile text editing strategy? Or can we just always choose the android strategy when OS == android and always choose ios strategy when OS == iOS
There was a problem hiding this comment.
I think it makes sense to remove the browser engine check here and see what happens.
One thing to keep in mind is that on iOS, all browsers have to use the Webkit engine under the hood (because iOS doesn't allow apps to ship their own JIT, and all browsers need a JIT, so they have to use Webkit from iOS). On Android, this isn't the case.
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. |
htoor3
force-pushed
the
fix-inputmode-firefox
branch
from
983e18e to
67b930b
Compare
…143183) flutter/engine@fb99a84...6f5b6a3 2024-02-08 [email protected] [web] - Fix `inputmode` on Android Firefox (flutter/engine#46901) 2024-02-08 [email protected] [Impeller] Vulkan: Don't fail initialization if stencil-only textures aren't supported. (flutter/engine#50455) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
The wrong keyboard type shows when users specify the phone input type in the framework.
This is happening because:
inputmodefor mobile text editing strategies.Fixes flutter/flutter#136351
Pre-launch Checklist
///).