This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use --timeline_recorder=systrace instead of --systrace_timeline #46884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
approved these changes
Oct 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 13, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 13, 2023
…136553) flutter/engine@93f02f7...799e8de 2023-10-13 [email protected] Roll Skia from 643d74cf4e0b to 4783e1146146 (2 revisions) (flutter/engine#46890) 2023-10-13 [email protected] Roll Dart SDK from 95e2ecee106a to c8143a7c026f (1 revision) (flutter/engine#46889) 2023-10-13 [email protected] Roll Skia from 77e73bb2744b to 643d74cf4e0b (2 revisions) (flutter/engine#46888) 2023-10-13 [email protected] Use --timeline_recorder=systrace instead of --systrace_timeline (flutter/engine#46884) 2023-10-13 [email protected] fixed AutofillHints.middleName tanslation for web. (flutter/engine#46429) 2023-10-13 [email protected] Roll Skia from 3acf82dcc479 to 77e73bb2744b (2 revisions) (flutter/engine#46886) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
`--systrace_timeline` is redundant and makes the `getFlagList` VM Service RPC not return `timeline_recorder=systrace` (flutter/devtools#6524 (comment)), so we would like to deprecate and remove it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--systrace_timelineis redundant and makes thegetFlagListVM Service RPC not returntimeline_recorder=systrace(flutter/devtools#6524 (comment)), so we would like to deprecate and remove it.