-
Notifications
You must be signed in to change notification settings - Fork 6k
Fix --no-prebuilt-dart-sdk build #46842
Conversation
|
auto label is removed for flutter/engine/46842, due to - The status or check suite Linux linux_web_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
I had started looking at this, and IIUC the So I'd suggest:
|
|
Also, after applying the fix I'm still seeing errors when configuring an Android build with |
641c475 to
bad615b
Compare
|
@jason-simmons Good catch. I've updated the PR. |
| deps = common_deps | ||
| pool = "//flutter/build/dart:dart_pool" | ||
| script = "$root_gen_dir/frontend_server.dart.snapshot" | ||
| packages = rebase_path(invoker.package_config) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is redundant with the logic above in all cases.
|
With this patch I'm still seeing errors when building a 32-bit When it builds the scenario app snapshot, the frontend server fails with: |
bad615b to
971c37b
Compare
|
It turns out that when not using the prebuilt Dart SDK, we were previously running the frontend server from source. I've updated this patch to go back to that behavior. Thanks, Jason! |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Will merge this into the reland of #46863 |
Fix for previous commit #46440