Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@mossmana
Copy link
Contributor

Addresses: flutter/flutter#130828

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mossmana mossmana added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 13, 2023
@auto-submit auto-submit bot merged commit d88bac3 into flutter:main Oct 13, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 13, 2023
…136558)

flutter/engine@799e8de...6605151

2023-10-13 [email protected] [Impeller] Only allow Impeller in flutter_tester if vulkan is enabled. (flutter/engine#46895)
2023-10-13 [email protected] Roll Skia from 4783e1146146 to e10e6765480a (1 revision) (flutter/engine#46893)
2023-10-13 [email protected] Replace deprecated [UIScreen mainScreen] in FlutterView.mm (flutter/engine#46802)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace deprecated [UIScreen mainScreen] in FlutterView.mm

3 participants