This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Bump impeller-cmake #46764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
(Only because CI is having problems.) You can get the Impeller cmake example to run in presubmit, by temporarily changing the .ci.yaml file to remove |
Member
Author
|
Removed bringup and got a successful build: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20impeller-cmake-example/22/overview Returning it before landing. :) |
bdero
force-pushed
the
bdero/bump-impeller-cmake-20231011
branch
from
88c0c53 to
1f1d2cd
Compare
zanderso
approved these changes
Oct 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 12, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 12, 2023
…136431) flutter/engine@05e26c1...d00fabf 2023-10-12 [email protected] Roll Skia from 924df8d87766 to ff3c2e3d45bd (1 revision) (flutter/engine#46807) 2023-10-11 [email protected] Roll Dart SDK from 0732be6b823a to db2465f106ad (8 revisions) (flutter/engine#46797) 2023-10-11 [email protected] [Impeller] Use triangle strips to dedupe rectangle vertices. (flutter/engine#46610) 2023-10-11 [email protected] [Impeller] Bump impeller-cmake (flutter/engine#46764) 2023-10-11 [email protected] Roll Skia from 2459d71707e0 to 924df8d87766 (7 revisions) (flutter/engine#46798) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
Bump with build fixes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump with build fixes.