This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Adds Noto Music fallback font #46720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
This should be good to go, PTAL web team! |
Member
|
|
mdebbar
approved these changes
Oct 11, 2023
Author
|
Fixes flutter/devtools#6149 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 11, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 11, 2023
…136414) flutter/engine@2b1b4b9...8bf1460 2023-10-11 [email protected] Revert "[Android] Add support for text processing actions (#44579)" (flutter/engine#46788) 2023-10-11 [email protected] [web] Adds Noto Music fallback font (flutter/engine#46720) 2023-10-11 [email protected] Fix some image_external_texture entries in the license golden file (flutter/engine#46790) 2023-10-11 [email protected] Rename HardwareBufferExternalTexture* to ImageExternalTexture* (flutter/engine#46786) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
Adds `Noto Music` font as a fallback font, and updates DEPS and font definitions after running the font roller script. ### Issues Fixes: flutter/devtools#6149 ----  I used [the developer API](https://developers.google.com/fonts/docs/developer_api?apix_params=%7B%22family%22%3A%5B%22Noto%20Music%22%5D%7D) to make sure the api works with this font. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Noto Musicfont as a fallback font, and updates DEPS and font definitions after running the font roller script.Issues
Fixes: flutter/devtools#6149
I used the developer API to make sure the api works with this font.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.