This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Add IMPELLER_DEBUG around group. #46642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
changed the title
chinmaygarde
approved these changes
Oct 7, 2023
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
I mentioned this in a previous review. But how about just patching the proc table to make these no-ops when IMPELLER_DEBUG is unset? For instance, the way we do it for the framebuffer discard extensions.
Contributor
Author
|
Done! |
Contributor
Author
|
actually wont work since I also ifdef out the cmd label. RIP |
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 7, 2023
…136141) flutter/engine@8711c1f...a18c527 2023-10-07 [email protected] [Impeller] Add IMPELLER_DEBUG around group. (flutter/engine#46642) 2023-10-07 [email protected] Roll Skia from 6ce883877068 to 99d9d571f4dd (1 revision) (flutter/engine#46652) 2023-10-07 [email protected] Roll Fuchsia Linux SDK from a-BbzDtY3w8UXYgbK... to nX88TgPdoM6PK1wBq... (flutter/engine#46651) 2023-10-07 [email protected] Roll Fuchsia Mac SDK from GXgrnmetc14RPdheo... to NRLsjEUCmIz2f1Wox... (flutter/engine#46649) 2023-10-07 [email protected] Roll Skia from 15de5cc6a095 to 6ce883877068 (1 revision) (flutter/engine#46648) 2023-10-07 [email protected] Roll Dart SDK from 7ba556c43d35 to a88ed8cafd27 (1 revision) (flutter/engine#46647) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from a-BbzDtY3w8U to nX88TgPdoM6P fuchsia/sdk/core/mac-amd64 from GXgrnmetc14R to NRLsjEUCmIz2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…lutter#136141) flutter/engine@8711c1f...a18c527 2023-10-07 [email protected] [Impeller] Add IMPELLER_DEBUG around group. (flutter/engine#46642) 2023-10-07 [email protected] Roll Skia from 6ce883877068 to 99d9d571f4dd (1 revision) (flutter/engine#46652) 2023-10-07 [email protected] Roll Fuchsia Linux SDK from a-BbzDtY3w8UXYgbK... to nX88TgPdoM6PK1wBq... (flutter/engine#46651) 2023-10-07 [email protected] Roll Fuchsia Mac SDK from GXgrnmetc14RPdheo... to NRLsjEUCmIz2f1Wox... (flutter/engine#46649) 2023-10-07 [email protected] Roll Skia from 15de5cc6a095 to 6ce883877068 (1 revision) (flutter/engine#46648) 2023-10-07 [email protected] Roll Dart SDK from 7ba556c43d35 to a88ed8cafd27 (1 revision) (flutter/engine#46647) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from a-BbzDtY3w8U to nX88TgPdoM6P fuchsia/sdk/core/mac-amd64 from GXgrnmetc14R to NRLsjEUCmIz2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
These tracing functions aren't free!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tracing functions aren't free!