This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Remove hardcoded fuchsia-imported packages 2.12 sdk version #46629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use version from package pubspec.yaml instead. This unblocks dart->engine roll that currently is failing https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Fuchsia/83386/overview.
zanderso
approved these changes
Oct 6, 2023
aam
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 6, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 6, 2023
…136098) flutter/engine@eb5d5c6...7bf93bb 2023-10-06 [email protected] [fuchsia] Remove hardcoded fuchsia-imported packages 2.12 sdk version (flutter/engine#46629) 2023-10-06 [email protected] Add Base64::EncodedSize to tidy up allocations (flutter/engine#46624) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…lutter#136098) flutter/engine@eb5d5c6...7bf93bb 2023-10-06 [email protected] [fuchsia] Remove hardcoded fuchsia-imported packages 2.12 sdk version (flutter/engine#46629) 2023-10-06 [email protected] Add Base64::EncodedSize to tidy up allocations (flutter/engine#46624) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
…#46629) Use sdk version from imported package pubspec.yaml instead. This unblocks dart->engine roll that currently is failing https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Fuchsia/83386/overview.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use sdk version from imported package pubspec.yaml instead.
This unblocks dart->engine roll that currently is failing https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Fuchsia/83386/overview.