[Impeller] Use triangle strips to dedupe rectangle vertices. #46610
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
So if you change these from triangle, the default constructed PSO won't match anymore for these. Though if we're going to unconditionally use triangle strip, you could probably change the initialization code to specify that geometry instead?
bdero
force-pushed
the
bdero/triangle-strips
branch
from
f5aedd1 to
9b85baf
Compare
Done. I also got the ordering wrong on some of these. Let's see those new goldens. |
|
Golden file changes are available for triage from new commit, Click here to view. |
|
Golden file changes are available for triage from new commit, Click here to view. |
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
You will probably need to update default_options L832 content_context.h
|
I'm working on a solution for tracking different prototype defaults for different pipeline sets here: #46751 |
bdero
force-pushed
the
bdero/triangle-strips
branch
from
1bd7731 to
28b1efc
Compare
|
This should be good now. This is using the new solution for differing defaults and the goldens are looking good. :) |
|
The previous solution I tried to employ in this patch didn't work as intended due to the mismatching default lookup in the |
…136431) flutter/engine@05e26c1...d00fabf 2023-10-12 [email protected] Roll Skia from 924df8d87766 to ff3c2e3d45bd (1 revision) (flutter/engine#46807) 2023-10-11 [email protected] Roll Dart SDK from 0732be6b823a to db2465f106ad (8 revisions) (flutter/engine#46797) 2023-10-11 [email protected] [Impeller] Use triangle strips to dedupe rectangle vertices. (flutter/engine#46610) 2023-10-11 [email protected] [Impeller] Bump impeller-cmake (flutter/engine#46764) 2023-10-11 [email protected] Roll Skia from 2459d71707e0 to 924df8d87766 (7 revisions) (flutter/engine#46798) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Remove a couple of duplicate verts in a bunch of situations. Pedantic improvements: "Brandon, why are you like this" edition.
2 participants
Remove a couple of duplicate verts in a bunch of situations.
Pedantic improvements: "Brandon, why are you like this" edition.