This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Stencil -> Clip #46519
Merged
[Impeller] Stencil -> Clip #46519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdero
force-pushed
the
bdero/rename-stencil-coverage
branch
from
389e7c3 to
a9262a4
Compare
chinmaygarde
approved these changes
Oct 3, 2023
Member
|
Don't know about the days being numbered but this reads better for sure :) |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 3, 2023
…135937) flutter/engine@be64d0c...8ab7c88 2023-10-03 [email protected] Opt out `flutter/third_party/**` from clang-tidy checks explicitly. (flutter/engine#46514) 2023-10-03 [email protected] [Impeller] Stencil -> Clip (flutter/engine#46519) 2023-10-03 [email protected] Roll Skia from b708dd7d1092 to c66c89c56549 (1 revision) (flutter/engine#46521) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…lutter#135937) flutter/engine@be64d0c...8ab7c88 2023-10-03 [email protected] Opt out `flutter/third_party/**` from clang-tidy checks explicitly. (flutter/engine#46514) 2023-10-03 [email protected] [Impeller] Stencil -> Clip (flutter/engine#46519) 2023-10-03 [email protected] Roll Skia from b708dd7d1092 to c66c89c56549 (1 revision) (flutter/engine#46521) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
The days of using the stencil buffer for clip tracking may be numbered, so move away from mentioning the stencil buffer for concepts that are actually about clips.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The days of using the stencil buffer for clip tracking may be numbered, so move away from mentioning the stencil buffer for concepts that are actually about clips.