Restrict ImageReader backed Platform Views to Android 33+ #46478
Conversation
This is necessary to be able to access the fence associated with each frame that is produced. This API is not available below 33.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| SyncFence fence = r.getFence(); | ||
| boolean signaled = fence.awaitForever(); |
There was a problem hiding this comment.
😢
Not necessary to do now, but we might be able to get the Vulkan drive to do the waiting via something like https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VkExternalFenceHandleTypeFlagBits.html
There was a problem hiding this comment.
I'm not sure it is possible to convert a SyncFence into a file descriptor (although it is possible to serialize into a Parceable and manually extracting the fd -- just unclear on how stable the parceable format is).
There was a problem hiding this comment.
Yeah I'm not sure if that is exactly the right API, just that I thought there was something like that
…135887) flutter/engine@5bc3ab5...1549d58 2023-10-03 [email protected] Roll Fuchsia Linux SDK from ZzYmXHUmcE0gMgZn1... to HZHIjaqYGV-JOwWfn... (flutter/engine#46483) 2023-10-03 [email protected] Restrict ImageReader backed Platform Views to Android 33+ (flutter/engine#46478) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from ZzYmXHUmcE0g to HZHIjaqYGV-J If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#135887) flutter/engine@5bc3ab5...1549d58 2023-10-03 [email protected] Roll Fuchsia Linux SDK from ZzYmXHUmcE0gMgZn1... to HZHIjaqYGV-JOwWfn... (flutter/engine#46483) 2023-10-03 [email protected] Restrict ImageReader backed Platform Views to Android 33+ (flutter/engine#46478) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from ZzYmXHUmcE0g to HZHIjaqYGV-J If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This is necessary to be able to access the fence associated with each frame that is produced. This API is not available below 33.
2 participants
This is necessary to be able to access the fence associated with each frame that is produced. This API is not available below 33.