Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove the frontend server wrapper #46440

Merged
auto-submit merged 1 commit into from
Oct 12, 2023
Merged

Remove the frontend server wrapper #46440

auto-submit merged 1 commit into from
Oct 12, 2023

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Sep 30, 2023 •
edited
Loading

Instead, this PR copies the frontend server from the Dart SDK (whether prebuilt or not) into the location expected by internal engine tests and artifact construction. This PR also consolidates the three GN templates that invoked the frontend server down to one.

Framework presubs: flutter/flutter#135836

Related: flutter/flutter#60007

@zanderso zanderso force-pushed the rm-ffes branch 8 times, most recently from 7704029 to dddf413 Compare October 1, 2023 19:54
@zanderso zanderso mentioned this pull request Oct 1, 2023
Closed
@zanderso zanderso force-pushed the rm-ffes branch 3 times, most recently from 2efbbc0 to a6e04e0 Compare October 5, 2023 20:08
@zanderso
Copy link
Member Author

zanderso commented Oct 10, 2023

@dnfield @jason-simmons friendly ping

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 12, 2023
@auto-submit auto-submit bot merged commit f020067 into flutter:main Oct 12, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
f02006736 Remove the frontend server wrapper (flutter/engine#46440)
525e94e
@aam
Copy link
Member

aam commented Oct 12, 2023 •
edited
Loading

This seems to have broken --no-prebuilt-dart-sdk build:

─➤  flutter/tools/gn --no-prebuilt-dart-sdk --runtime-mode debug && ninja -C out/host_debug
Generating GN files in: out/host_debug
ERROR at //flutter/build/dart/rules.gni:113:38: No value named "package_config" in scope "invoker"
      packages = rebase_path(invoker.package_config)
                                     ^-------------
See //flutter/testing/testing.gni:82:3: whence it was called.
  flutter_frontend_server(target_name) {
  ^-------------------------------------
See //flutter/testing/testing.gni:156:3: whence it was called.
  dart_snapshot_kernel(dart_snapshot_kernel_target_name) {
  ^-------------------------------------------------------
See //flutter/testing/testing.gni:291:5: whence it was called.
    dart_snapshot(dart_snapshot_target_name) {
    ^-----------------------------------------
See //flutter/third_party/tonic/tests/BUILD.gn:7:1: whence it was called.
test_fixtures("tonic_fixtures") {
^--------------------------------
See //flutter/BUILD.gn:174:7: which caused the file to be included.
      "//flutter/third_party/tonic/tests:tonic_unittests",
      ^--------------------------------------------------

@aam aam mentioned this pull request Oct 12, 2023
Closed
@zanderso zanderso deleted the rm-ffes branch October 12, 2023 17:46
@zanderso
Copy link
Member Author

zanderso commented Oct 12, 2023

I have a fix. Will upload shortly.

@zanderso zanderso mentioned this pull request Oct 12, 2023
Closed
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 664657d32992 to f02006736390 (3 revisions) (#…
90b24fb 
…136467)

flutter/engine@664657d...f020067

2023-10-12 [email protected] Remove the frontend server wrapper (flutter/engine#46440)
2023-10-12 [email protected] Roll SwiftShader to include a fix required by the latest Clang toolchain (flutter/engine#46803)
2023-10-12 [email protected] Roll Skia from 2dd1579c6921 to 1d134a8f3ae2 (5 revisions) (flutter/engine#46824)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zanderso added a commit that referenced this pull request Oct 13, 2023
@zanderso
Revert "Remove the frontend server wrapper (#46440)"
936d297 
This reverts commit f020067.
@zanderso zanderso mentioned this pull request Oct 13, 2023
Merged
zanderso added a commit that referenced this pull request Oct 13, 2023
@zanderso
Revert "Remove the frontend server wrapper" (#46863)
7a6172e 
Reverts #46440

For b/305121780
@zanderso zanderso mentioned this pull request Oct 17, 2023
Merged
auto-submit bot pushed a commit that referenced this pull request Oct 18, 2023
@zanderso
Reland: Remove the frontend server wrapper (#47010)
4cd0e19 
Relands #46440 with #46842
harryterkelsen pushed a commit that referenced this pull request Oct 23, 2023
@zanderso @harryterkelsen
Remove the frontend server wrapper (#46440)
2c00897 
Instead, this PR copies the frontend server from the Dart SDK (whether prebuilt or not) into the location expected by internal engine tests and artifact construction. This PR also consolidates the three GN templates that invoked the frontend server down to one.

Framework presubs: flutter/flutter#135836

Related: flutter/flutter#60007
harryterkelsen pushed a commit that referenced this pull request Oct 23, 2023
@zanderso @harryterkelsen
Revert "Remove the frontend server wrapper" (#46863)
be8607a 
Reverts #46440

For b/305121780
harryterkelsen pushed a commit that referenced this pull request Oct 23, 2023
@zanderso @harryterkelsen
Reland: Remove the frontend server wrapper (#47010)
5c9384d 
Relands #46440 with #46842
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dnfield dnfield Awaiting requested review from dnfield

1 more reviewer

@jason-simmons jason-simmons jason-simmons approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zanderso @aam @jason-simmons