[Impeller] Make some Open GL errors non-fatal, check in debug mode (not unopt). #46434
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
changed the title
…ug mode (not unopt). (flutter/engine#46434)
…135808) flutter/engine@68fc1a5...01fc3c6 2023-09-30 [email protected] [Impeller] Make some Open GL errors non-fatal, check in debug mode (not unopt). (flutter/engine#46434) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
There are a few failures in the devicelab from this change. (In bringup so the tree is not closed.) Here is an example: https://ci.chromium.org/ui/p/flutter/builders/staging/Linux_pixel_7pro%20animated_blur_backdrop_filter_perf_opengles__timeline_summary/714/overview |
|
This is likely a misconfiguration in the texture to texture blit, the only places where glBlitFramebuffer is used. Thankfully we have a capabilities check for this and can disable it: https://github.com/flutter/engine/blob/main/impeller/renderer/capabilities.cc#L32C8-L32C37 |
…lutter#135808) flutter/engine@68fc1a5...01fc3c6 2023-09-30 [email protected] [Impeller] Make some Open GL errors non-fatal, check in debug mode (not unopt). (flutter/engine#46434) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
4 participants
Closes flutter/flutter#135767.