Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

fixed AutofillHints.middleName tanslation for web. #46429

Merged
auto-submit merged 4 commits into from
Oct 13, 2023
Merged

fixed AutofillHints.middleName tanslation for web. #46429

auto-submit merged 4 commits into from
Oct 13, 2023

Conversation

@eriko13
Copy link
Contributor

@eriko13 eriko13 commented Sep 29, 2023 •
edited
Loading

This PR fixes the AutofillHints.middleName has no effect on TextField in Web bug.

Screenshot 2023-09-30 at 1 18 03 p m

Closes #135542

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 29, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Sep 29, 2023
htoor3
htoor3 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@htoor3 htoor3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you for the change!

@eriko13
Copy link
Contributor Author

eriko13 commented Oct 10, 2023

@htoor3 Thanks for the review! How can I merge this into main?

@htoor3 htoor3 added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 10, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 10, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 10, 2023

auto label is removed for flutter/engine/46429, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@htoor3 htoor3 requested a review from Renzo-Olivares October 10, 2023 17:38
@htoor3
Copy link
Contributor

htoor3 commented Oct 10, 2023

@htoor3 Thanks for the review! How can I merge this into main?

Looks like we need an additional review - once you get an additional approval, you can add the autosubmit label which should automatically merge the PR for you when the tree is green

Renzo-Olivares
Renzo-Olivares approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you for the contribution!

@eriko13
Copy link
Contributor Author

eriko13 commented Oct 13, 2023 •
edited
Loading

Thank you! @htoor3 @Renzo-Olivares

Again, I can’t add the autosubmit label by myself, can one of you add it?

@htoor3 htoor3 added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 13, 2023
@auto-submit auto-submit bot merged commit 67c162b into flutter:main Oct 13, 2023
@eriko13 eriko13 deleted the fix-AutofillHints.middleName-has-no-effect-on-TextField-in-Web-135542 branch October 13, 2023 17:16
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 13, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 13, 2023
@engine-flutter-autoroll
67c162bb9 fixed AutofillHints.middleName tanslation for web. (flutter…
8c993ff 
…/engine#46429)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 13, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 93f02f7237db to 799e8de11c12 (6 revisions) (#…
cff36c9 
…136553)

flutter/engine@93f02f7...799e8de

2023-10-13 [email protected] Roll Skia from 643d74cf4e0b to 4783e1146146 (2 revisions) (flutter/engine#46890)
2023-10-13 [email protected] Roll Dart SDK from 95e2ecee106a to c8143a7c026f (1 revision) (flutter/engine#46889)
2023-10-13 [email protected] Roll Skia from 77e73bb2744b to 643d74cf4e0b (2 revisions) (flutter/engine#46888)
2023-10-13 [email protected] Use --timeline_recorder=systrace instead of --systrace_timeline (flutter/engine#46884)
2023-10-13 [email protected] fixed AutofillHints.middleName tanslation for web. (flutter/engine#46429)
2023-10-13 [email protected] Roll Skia from 3acf82dcc479 to 77e73bb2744b (2 revisions) (flutter/engine#46886)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen pushed a commit that referenced this pull request Oct 23, 2023
@eriko13 @harryterkelsen
fixed AutofillHints.middleName tanslation for web. (#46429)
7b2a71a 
This PR fixes the AutofillHints.middleName has no effect on TextField in Web bug.

<img width="1440" alt="Screenshot 2023-09-30 at 1 18 03�p m" src="https://github.com/flutter/engine/assets/36830415/f6643b71-3944-42da-a9b4-47e1cebb290e">

Closes [#135542](flutter/flutter#135542)

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

@htoor3 htoor3 htoor3 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AutofillHints.middleName has no effect on TextField in Web.

3 participants

@eriko13 @htoor3 @Renzo-Olivares