This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "[Impeller] simplify invert colors flag by supporting composed color filters." #46414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-submit
bot
added
the
revert of
fluttergithubbot
approved these changes
Sep 29, 2023
auto-submit
bot
deleted the
revert_7326ccb71625daa73ea7002a83ce980787cdf553
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 29, 2023
…ng composed color filters." (flutter/engine#46414)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 29, 2023
…135765) flutter/engine@d5fcd78...48973d7 2023-09-29 [email protected] Manual roll Dart SDK from e042e83c85a5 to 955a3a964621 (2 revisions) (flutter/engine#46412) 2023-09-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] simplify invert colors flag by supporting composed color filters." (flutter/engine#46414) 2023-09-29 [email protected] [Impeller] simplify invert colors flag by supporting composed color filters. (flutter/engine#46391) 2023-09-29 [email protected] Manual roll Dart SDK from 077d768accfa to e042e83c85a5 (3 revisions) (flutter/engine#46409) 2023-09-29 [email protected] Roll Skia from 9f8242377455 to 2d4045f55fd5 (3 revisions) (flutter/engine#46408) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…lutter#135765) flutter/engine@d5fcd78...48973d7 2023-09-29 [email protected] Manual roll Dart SDK from e042e83c85a5 to 955a3a964621 (2 revisions) (flutter/engine#46412) 2023-09-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] simplify invert colors flag by supporting composed color filters." (flutter/engine#46414) 2023-09-29 [email protected] [Impeller] simplify invert colors flag by supporting composed color filters. (flutter/engine#46391) 2023-09-29 [email protected] Manual roll Dart SDK from 077d768accfa to e042e83c85a5 (3 revisions) (flutter/engine#46409) 2023-09-29 [email protected] Roll Skia from 9f8242377455 to 2d4045f55fd5 (3 revisions) (flutter/engine#46408) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
…d color filters." (#46414) Reverts #46391 Initiated by: jonahwilliams This change reverts the following previous change: Original Description: Fixes flutter/flutter#135699 To avoid the ugly complicated code for conditionally applying both colorfilters, make the dl dispatcher handle merging these filters together in a defined order. The original bug is caused by not checking for invert colors in a CPU fast path.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #46391
Initiated by: jonahwilliams
This change reverts the following previous change:
Original Description:
Fixes flutter/flutter#135699
To avoid the ugly complicated code for conditionally applying both colorfilters, make the dl dispatcher handle merging these filters together in a defined order. The original bug is caused by not checking for invert colors in a CPU fast path.