This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Fix OpenGLES EGL_BAD_ACCESS due to context being current on multiple threads. #46287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jwinarske
force-pushed
the
jw/egl_bad_access
branch
from
19d450f to
33c0688
Compare
2 tasks
-On Linux setting the EGL context from one thread, then setting from another thread will trigger a EGL_BAD_ACCESS error. The resolution is to clear the context after use on the thread that set it. -remote call to SetReactionsAllowedOnCurrentThread(), as it defaults to false. Signed-off-by: Joel Winarske <[email protected]>
jwinarske
force-pushed
the
jw/egl_bad_access
branch
from
33c0688 to
9adbf5c
Compare
2 tasks
jonahwilliams
added
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/46287, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.
|
auto-submit
bot
removed
the
autosubmit
chinmaygarde
changed the title
chinmaygarde
changed the title
chinmaygarde
approved these changes
Sep 28, 2023
chinmaygarde
added
the
autosubmit
Member
|
@jwinarske Would you mind having contributor access? |
Contributor
Author
|
@chinmaygarde sure |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 28, 2023
… current on multiple threads. (flutter/engine#46287)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 28, 2023
…135717) flutter/engine@cc7c3c1...485543c 2023-09-28 [email protected] Roll Fuchsia Linux SDK from cu6apvEZ2P6zhishc... to l2RxJKPfYn7QzGOoL... (flutter/engine#46382) 2023-09-28 [email protected] Remove opacity layer dcheck. (flutter/engine#46160) 2023-09-28 [email protected] Add initial support for 4x MSAA in OpenGLES backend. (flutter/engine#46381) 2023-09-28 [email protected] Reland: [macOS] performKeyEquivalent cleanup (flutter/engine#46377) 2023-09-28 [email protected] [macOS] TextInputPlugin should mark navigation events in IME popover as handled (flutter/engine#46141) 2023-09-28 [email protected] Removed unnecessary dynamic dispatch (flutter/engine#46369) 2023-09-28 [email protected] [Impeller] Fix OpenGLES EGL_BAD_ACCESS due to context being current on multiple threads. (flutter/engine#46287) 2023-09-28 [email protected] Fix damage calculation when not providing populate_existing_damage for gl embedder (flutter/engine#45611) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from cu6apvEZ2P6z to l2RxJKPfYn7Q If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…lutter#135717) flutter/engine@cc7c3c1...485543c 2023-09-28 [email protected] Roll Fuchsia Linux SDK from cu6apvEZ2P6zhishc... to l2RxJKPfYn7QzGOoL... (flutter/engine#46382) 2023-09-28 [email protected] Remove opacity layer dcheck. (flutter/engine#46160) 2023-09-28 [email protected] Add initial support for 4x MSAA in OpenGLES backend. (flutter/engine#46381) 2023-09-28 [email protected] Reland: [macOS] performKeyEquivalent cleanup (flutter/engine#46377) 2023-09-28 [email protected] [macOS] TextInputPlugin should mark navigation events in IME popover as handled (flutter/engine#46141) 2023-09-28 [email protected] Removed unnecessary dynamic dispatch (flutter/engine#46369) 2023-09-28 [email protected] [Impeller] Fix OpenGLES EGL_BAD_ACCESS due to context being current on multiple threads. (flutter/engine#46287) 2023-09-28 [email protected] Fix damage calculation when not providing populate_existing_damage for gl embedder (flutter/engine#45611) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from cu6apvEZ2P6z to l2RxJKPfYn7Q If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
…n multiple threads. (#46287) On Linux setting the EGL context from one thread, then setting from another thread will trigger a EGL_BAD_ACCESS error. The resolution is to clear the context after use on the thread that set it. flutter/flutter#130619
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux setting the EGL context from one thread, then setting from another thread will trigger a EGL_BAD_ACCESS error. The resolution is to clear the context after use on the thread that set it.
flutter/flutter#130619
Pre-launch Checklist
///).