Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reland "[Impeller] Fail if software backend is chosen and Impeller is enabled on iOS." #46275

Merged
auto-submit merged 2 commits into from
Nov 17, 2023
Merged

Reland "[Impeller] Fail if software backend is chosen and Impeller is enabled on iOS." #46275

auto-submit merged 2 commits into from
Nov 17, 2023

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Sep 25, 2023

Reverts #46217

cl/568091248 makes this safe to land again.

fyi @jonahwilliams @chinmaygarde

@chingjun
Copy link
Contributor

chingjun commented Sep 25, 2023

Let's hold the reland until the fixes for other tests are submitted. Thanks.

@dnfield
Copy link
Contributor Author

dnfield commented Sep 25, 2023

Is that cl/567703381?

@dnfield
Copy link
Contributor Author

dnfield commented Sep 28, 2023

I think this is waiting for cl/567703381

@chinmaygarde chinmaygarde changed the title Reland "[Impeller] fail if software backend is chosen and Impeller is enabled on iOS" Reland "[Impeller] Fail if software backend is chosen and Impeller is enabled on iOS" Oct 12, 2023
@chinmaygarde chinmaygarde changed the title Reland "[Impeller] Fail if software backend is chosen and Impeller is enabled on iOS" Reland "[Impeller] Fail if software backend is chosen and Impeller is enabled on iOS." Oct 12, 2023
@chinmaygarde
Copy link
Member

chinmaygarde commented Oct 12, 2023

The linked CL has been approved but still not landed. Is there a blocker? No hurry.

@dnfield
Copy link
Contributor Author

dnfield commented Oct 13, 2023

I believe the ask was for @jiahaog to take al ook at the ios_test related build rules to make sure this wouldn't be too disruptive.

Something will need to be done here, because internal authors want to run tests that initialize a FlutterViewController even if they don't render anything, but this change will make that fail if it's not possible to get a MTLDevice

@chinmaygarde
Copy link
Member

chinmaygarde commented Oct 19, 2023 •
edited
Loading

because internal authors want to run tests that initialize a FlutterViewController even if they don't render anything

I don't think we should support this broken configuration. Can they mock it instead?

Triage: We'll circle back to this when @chingjun is back.

@zanderso
Copy link
Member

zanderso commented Nov 2, 2023

From PR review triage: This is waiting on b/301315893 (maybe among others? cc @jiahaog)

@jonahwilliams jonahwilliams mentioned this pull request Nov 2, 2023
Closed
8 tasks
@jiahaog
Copy link
Member

jiahaog commented Nov 2, 2023

Yes, I've sent out changes to all affected clients and we're pending reviews from them.

jiahaog
jiahaog approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@jiahaog jiahaog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those clients should no longer be using a "real" Flutter Engine in the unsupported test configuration. We should be able to land this now.

@zanderso
Copy link
Member

zanderso commented Nov 6, 2023

This PR likely needs a rebase before landing.

@chinmaygarde chinmaygarde force-pushed the revert-46217-revert-46124-soft_fail branch from f9daef1 to da2b93d Compare November 9, 2023 21:04
@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 9, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 9, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Nov 9, 2023

auto label is removed for flutter/engine/46275, due to - The status or check suite Linux mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@zanderso zanderso force-pushed the revert-46217-revert-46124-soft_fail branch from da2b93d to a77c643 Compare November 10, 2023 15:41
@dnfield
Copy link
Contributor Author

dnfield commented Nov 10, 2023

@jiahaog is this ok to land now?

@zanderso
Copy link
Member

zanderso commented Nov 10, 2023

@dnfield The mac_unopt tests appear to have failures that might be related to this PR: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/510350/overview

@jiahaog
Copy link
Member

jiahaog commented Nov 13, 2023

@dnfield yes, have already migrated the breaking clients away.

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 13, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 13, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Nov 13, 2023

auto label is removed for flutter/engine/46275, due to - The status or check suite Linux mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 16, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 16, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Nov 16, 2023

auto label is removed for flutter/engine/46275, due to - The status or check suite Linux mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@dnfield dnfield force-pushed the revert-46217-revert-46124-soft_fail branch from e7e0c73 to 0c8ff91 Compare November 17, 2023 04:54
@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 17, 2023
@dnfield
Copy link
Contributor Author

dnfield commented Nov 17, 2023

Many tests were providing a nil gpu sync switch, which was now crashing after #46840. Updated the tests to provide a valid sync switch pointer.

@auto-submit auto-submit bot merged commit 141a01c into main Nov 17, 2023
@auto-submit auto-submit bot deleted the revert-46217-revert-46124-soft_fail branch November 17, 2023 20:12
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 17, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 17, 2023
@engine-flutter-autoroll
141a01c5c Reland "[Impeller] Fail if software backend is chosen and I…
435f0c5 
…mpeller is enabled on iOS." (flutter/engine#46275)
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Nov 17, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 90c3ada3682c to 141a01c5c70b (16 revisions) (#…
30b6586 
…138637)

flutter/engine@90c3ada...141a01c

2023-11-17 [email protected] Reland "[Impeller] Fail if software backend is chosen and Impeller is enabled on iOS." (flutter/engine#46275)
2023-11-17 [email protected] Make `impeller/geometry/...` compatible with `.clang-tidy`. (flutter/engine#48154)
2023-11-17 [email protected] Make `impeller/{archivist|compiler|core|entity}/...` compatible with â�¦ (flutter/engine#48153)
2023-11-17 [email protected] Assign mojom `kSwitch` role to switches (flutter/engine#48146)
2023-11-17 [email protected] [web] Move scene DOM management to DomManager (flutter/engine#47460)
2023-11-17 [email protected] [Impeller] Unify around "transform" (flutter/engine#48184)
2023-11-17 [email protected] Roll Dart SDK from a9c212f2f54b to 03cddb5d740d (1 revision) (flutter/engine#48182)
2023-11-17 [email protected] Actually make `status_or.h` compatible with `.clang-tidy`. (flutter/engine#48151)
2023-11-17 [email protected] [Impeller] Cleanups to geometry interfaces. (flutter/engine#48180)
2023-11-17 [email protected] [web] Move all DOM creation to DomManager (flutter/engine#48123)
2023-11-17 [email protected] Reenable UnobstructedPlatformViewTests testMultiplePlatformViewsWithOverlays (flutter/engine#48139)
2023-11-17 [email protected] Roll Dart SDK from 46e8b18047eb to a9c212f2f54b (1 revision) (flutter/engine#48176)
2023-11-17 [email protected] Roll Skia from bcd22e8f95bc to 8e9e168418a0 (1 revision) (flutter/engine#48173)
2023-11-17 [email protected] Roll Fuchsia Linux SDK from M0zM3CJLIrd5lb0u0... to Bcq9TZdt-vtTSL5YH... (flutter/engine#48172)
2023-11-17 [email protected] Roll Skia from c8ee25282849 to bcd22e8f95bc (1 revision) (flutter/engine#48170)
2023-11-17 [email protected] [Flutter GPU] Add Textures. (flutter/engine#48118)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from M0zM3CJLIrd5 to Bcq9TZdt-vtT

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@jonahwilliams jonahwilliams mentioned this pull request Jan 31, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chingjun chingjun Awaiting requested review from chingjun

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

2 more reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@jiahaog jiahaog jiahaog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dnfield dnfield

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-ios

Projects

No open projects
Impeller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dnfield @chingjun @chinmaygarde @zanderso @jiahaog