This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] FlutterTextInputPlugin should clip to bounds #46142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knopp
force-pushed
the
135219_text_input_plugin_clip_to_bounds
branch
from
51b9890 to
9ff515a
Compare
cbracken
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/46142, due to - The status or check suite Mac mac_clang_tidy_presubmit has failed. Please fix the issues identified (or deflake) before re-applying this label. |
knopp
force-pushed
the
135219_text_input_plugin_clip_to_bounds
branch
from
9ff515a to
0913917
Compare
cbracken
approved these changes
Sep 28, 2023
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
re-lgtm with the clipToBounds fix.
cbracken
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 28, 2023
2 tasks
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 28, 2023
…135701) flutter/engine@dbb6093...cc7c3c1 2023-09-28 [email protected] [macOS] FlutterTextInputPlugin should clip to bounds (flutter/engine#46142) 2023-09-28 [email protected] Roll Skia from d8a71d549262 to 33502f9b0c7d (2 revisions) (flutter/engine#46375) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…lutter#135701) flutter/engine@dbb6093...cc7c3c1 2023-09-28 [email protected] [macOS] FlutterTextInputPlugin should clip to bounds (flutter/engine#46142) 2023-09-28 [email protected] Roll Skia from d8a71d549262 to 33502f9b0c7d (2 revisions) (flutter/engine#46375) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
Fixes flutter/flutter#135219 (formerly flutter/flutter#128956) [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#135219
(formerly flutter/flutter#128956)
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.