This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[CP][Impeller] Adds unit test to make sure we can encode bgr101010xr to png. #46103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng. (flutter#46007) fixes flutter/flutter#133942 This is current blocked on the skia bug: https://g-issues.skia.org/issues/300986800 Depends on skia fix: https://skia-review.googlesource.com/c/skia/+/757816 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
CaseyHillers
added
the
autosubmit
chinmaygarde
changed the title
Member
|
@CaseyHillers We are not sure what to do with this. The linked CP issue was closed but this patch is still open. |
CaseyHillers
approved these changes
Oct 12, 2023
CaseyHillers
added
autosubmit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry pick for #46007