This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] DOM objects implement JS object #46047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eyebrowsoffire
left a comment
eyebrowsoffire
left a comment
There was a problem hiding this comment.
Yes! Thank you for doing this!
srujzs
approved these changes
Sep 19, 2023
Contributor
srujzs
left a comment
srujzs
left a comment
There was a problem hiding this comment.
LGTM! At some point we may migrate all JS types to extension types for readability, but that'll be further down the road and we'll probably migrate this entire file to extension types before then.
mdebbar
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 19, 2023
jonahwilliams
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 19, 2023
…sions) (#135041) Manual roll requested by [email protected] flutter/engine@589bde9...28f14e6 2023-09-19 [email protected] Roll Skia from d54cf63f051b to d756a2f5665d (5 revisions) (flutter/engine#46048) 2023-09-19 [email protected] Update CI to Chrome 117 (flutter/engine#45842) 2023-09-19 [email protected] [web] DOM objects implement JS object (flutter/engine#46047) 2023-09-19 [email protected] Roll Skia from 91adc7d289f7 to d54cf63f051b (3 revisions) (flutter/engine#46043) 2023-09-19 [email protected] Roll Skia from 1e84aa4509cd to 91adc7d289f7 (2 revisions) (flutter/engine#46040) 2023-09-19 [email protected] Roll Dart SDK from 8ad823c03f26 to e7cd697bd0e9 (2 revisions) (flutter/engine#46039) 2023-09-19 [email protected] Roll Fuchsia Mac SDK from qy5FU4y6sx1FscCpd... to 06g6i7-5u8O-FOTSi... (flutter/engine#46038) 2023-09-19 [email protected] Add more missing Skia #includes (flutter/engine#46034) 2023-09-19 [email protected] [macOS,iOS] Expose channel buffers 'resize' and 'overflow' control co… (flutter/engine#44848) 2023-09-19 [email protected] Roll Dart SDK from 5b0e7bda1379 to 8ad823c03f26 (3 revisions) (flutter/engine#46028) 2023-09-19 [email protected] Roll Skia from 744807d740c7 to 1e84aa4509cd (4 revisions) (flutter/engine#46026) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from qy5FU4y6sx1F to 06g6i7-5u8O- If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 19, 2023
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…sions) (flutter#135041) Manual roll requested by [email protected] flutter/engine@589bde9...28f14e6 2023-09-19 [email protected] Roll Skia from d54cf63f051b to d756a2f5665d (5 revisions) (flutter/engine#46048) 2023-09-19 [email protected] Update CI to Chrome 117 (flutter/engine#45842) 2023-09-19 [email protected] [web] DOM objects implement JS object (flutter/engine#46047) 2023-09-19 [email protected] Roll Skia from 91adc7d289f7 to d54cf63f051b (3 revisions) (flutter/engine#46043) 2023-09-19 [email protected] Roll Skia from 1e84aa4509cd to 91adc7d289f7 (2 revisions) (flutter/engine#46040) 2023-09-19 [email protected] Roll Dart SDK from 8ad823c03f26 to e7cd697bd0e9 (2 revisions) (flutter/engine#46039) 2023-09-19 [email protected] Roll Fuchsia Mac SDK from qy5FU4y6sx1FscCpd... to 06g6i7-5u8O-FOTSi... (flutter/engine#46038) 2023-09-19 [email protected] Add more missing Skia #includes (flutter/engine#46034) 2023-09-19 [email protected] [macOS,iOS] Expose channel buffers 'resize' and 'overflow' control co… (flutter/engine#44848) 2023-09-19 [email protected] Roll Dart SDK from 5b0e7bda1379 to 8ad823c03f26 (3 revisions) (flutter/engine#46028) 2023-09-19 [email protected] Roll Skia from 744807d740c7 to 1e84aa4509cd (4 revisions) (flutter/engine#46026) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from qy5FU4y6sx1F to 06g6i7-5u8O- If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
Instead of doing `as JSAny` for DOM objects that are defined in static JS interop, let's make them `implements JSObject`? cc @eyebrowsoffire @srujzs thoughts?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of doing
as JSAnyfor DOM objects that are defined in static JS interop, let's make themimplements JSObject?cc @eyebrowsoffire @srujzs thoughts?