Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@vashworth
Copy link
Contributor

We recently upgraded a bot in the try pool to macOS 13 and I noticed a couple of tests have leaked through to it and we're not ready for tests to run on macOS 13 yet.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@vashworth vashworth requested a review from zanderso September 14, 2023 21:11
@vashworth vashworth changed the title Set macOS tests to run on macOS 12 Set tests to run on macOS 12 Sep 14, 2023
@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 14, 2023
@auto-submit auto-submit bot merged commit 6a1e9bf into flutter:main Sep 14, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 16, 2023
zanderso pushed a commit to flutter/flutter that referenced this pull request Sep 16, 2023
…ions) (#134856)

Manual roll requested by [email protected]

flutter/engine@67dd12f...5aa9db3

2023-09-15 [email protected] Roll Skia from 37ea783440ea to
7aa8bfaa63fc (1 revision) (flutter/engine#45861)
2023-09-14 [email protected] Roll Skia from 8c9e378c4902 to
37ea783440ea (1 revision) (flutter/engine#45859)
2023-09-14 [email protected] Reduce unnecessary
Dart_TimelineGetMicros call (flutter/engine#45637)
2023-09-14 [email protected] Roll Skia from 9b7c116ed6c2 to
8c9e378c4902 (3 revisions) (flutter/engine#45858)
2023-09-14 [email protected] Set tests to run
on macOS 12 (flutter/engine#45855)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
…ions) (flutter#134856)

Manual roll requested by [email protected]

flutter/engine@67dd12f...5aa9db3

2023-09-15 [email protected] Roll Skia from 37ea783440ea to
7aa8bfaa63fc (1 revision) (flutter/engine#45861)
2023-09-14 [email protected] Roll Skia from 8c9e378c4902 to
37ea783440ea (1 revision) (flutter/engine#45859)
2023-09-14 [email protected] Reduce unnecessary
Dart_TimelineGetMicros call (flutter/engine#45637)
2023-09-14 [email protected] Roll Skia from 9b7c116ed6c2 to
8c9e378c4902 (3 revisions) (flutter/engine#45858)
2023-09-14 [email protected] Set tests to run
on macOS 12 (flutter/engine#45855)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen pushed a commit that referenced this pull request Oct 23, 2023
We recently upgraded a bot in the try pool to macOS 13 and I noticed a couple of tests have leaked through to it and we're not ready for tests to run on macOS 13 yet.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
vashworth added a commit to vashworth/engine that referenced this pull request Nov 2, 2023
We recently upgraded a bot in the try pool to macOS 13 and I noticed a couple of tests have leaked through to it and we're not ready for tests to run on macOS 13 yet.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@vashworth vashworth mentioned this pull request Nov 2, 2023
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants