Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@godofredoc
Copy link
Contributor

CP: 0cf5971

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@nilsreichardt
Copy link
Contributor

@godofredoc Thanks for creating this cherry-pick request. I'm interested in learning how the cherry-pick process works and I read the wiki article. But for me it's unclear how to pick the right branch. Just out of curiosity: Why have you picked flutter-3.13-candidate.0 as target branch and not one of the other 19 branches?

@godofredoc
Copy link
Contributor Author

et branch and not one of the other 19 branches?

Several release candidate branches are created per week to go through additional testing. Once we are ready for a new release, one of the release candidate branches is selected based on alignment with dart-sdk and some test greeness criteria.

During the release process the candidate branch is promoted to stable or beta and the source release candidate branch is updated here: https://github.com/flutter/flutter/blob/stable/bin/internal/release-candidate-branch.version.

Hotfixes are applied as cherry-picks to the release candidate branch and then the release candidate branch is pushed to stable or beta.

Copy link
Contributor

@Jasguerrero Jasguerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 14, 2023
@auto-submit auto-submit bot merged commit bd986c5 into flutter:flutter-3.13-candidate.0 Sep 14, 2023
@godofredoc godofredoc deleted the flutter-3.13-candidate.0 branch September 14, 2023 23:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants