-
Notifications
You must be signed in to change notification settings - Fork 6k
Switch goma to reclient fro standalone targets #45804
Switch goma to reclient fro standalone targets #45804
Conversation
|
First run of benchmark: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_benchmarks/1/overview, which took 57 mins without hitting any cache; The android_emulator_tests: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_android_emulator_tests/2/overview, which took 13 mins with cache hit. |
|
In what situations will the build take 57 minutes? |
Where we do not have a single cache hit: |
|
My question is in what situations can we expect to not have a single cache hit. Is this something that will happen on every commit? Once a day? Once a week? |
I expect this happens only the first time of the build, where the cache is empty (Run your builds and tests using the remote cache). |
What does "the first time of the build" mean? The first time on any given commit? Or the first time with the repo? I'm also confused by the documentation at that link. It says, "the cache is empty, so all actions are executed locally". That is very different from goma, which I believe uses the remote workers to run the compile commands even when there isn't a cache hit? |
The first execution time with the task/builder, which should be the same with the repo. I should have pointed out that the link focuses on using remote cache for local runs (the topic right after is |
zanderso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. That all sounds hunky-dory to me, then.
|
I will monitor the coming builds to make sure things go well as expected. Landing now. |
…134791) flutter/engine@45bc430...67dd12f 2023-09-14 [email protected] Roll Dart SDK from d25e8d682c8f to 7e4d9f4d8e52 (3 revisions) (flutter/engine#45854) 2023-09-14 [email protected] Remove @pragma('vm:entry-point') annotations on members that aren't accessed from C++ (flutter/engine#45697) 2023-09-14 [email protected] Roll Skia from 6bc9f5886ddf to 9b7c116ed6c2 (1 revision) (flutter/engine#45853) 2023-09-14 [email protected] Switch linux_android_debug_engine from goma to reclient (flutter/engine#45345) 2023-09-14 [email protected] Switch goma to reclient fro standalone targets (flutter/engine#45804) 2023-09-14 [email protected] Handle external window's `WM_CLOSE` in lifecycle manager (flutter/engine#45840) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#134791) flutter/engine@45bc430...67dd12f 2023-09-14 [email protected] Roll Dart SDK from d25e8d682c8f to 7e4d9f4d8e52 (3 revisions) (flutter/engine#45854) 2023-09-14 [email protected] Remove @pragma('vm:entry-point') annotations on members that aren't accessed from C++ (flutter/engine#45697) 2023-09-14 [email protected] Roll Skia from 6bc9f5886ddf to 9b7c116ed6c2 (1 revision) (flutter/engine#45853) 2023-09-14 [email protected] Switch linux_android_debug_engine from goma to reclient (flutter/engine#45345) 2023-09-14 [email protected] Switch goma to reclient fro standalone targets (flutter/engine#45804) 2023-09-14 [email protected] Handle external window's `WM_CLOSE` in lifecycle manager (flutter/engine#45840) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Part of flutter/flutter#132701.