This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll devtools from acbc179425b4596b7c2ba7d9c4263077f2e18098 to adfb08… #45766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c95c626248b28cc60df3b085c12ad8758e The Dart SDK change https://dart-review.googlesource.com/c/sdk/+/324770 rolled devtools to a newer version. This will be rolled into Flutter engine by the autoroller, but until it is rolled, some triple-headed testing cannot automatically handle this update because it is a CIPD dependency. This rolls the dependency to the new version to fix the breakage on legacy triple-head testing. This PR is not needed (and will rebase to an empty change) once the Dart SDK is rolled to version 3.2.0-147.0.dev or later
mkustermann
approved these changes
Sep 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 13, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 13, 2023
…134650) flutter/engine@a8d7d81...5e671d5 2023-09-13 [email protected] Roll devtools from acbc179425b4596b7c2ba7d9c4263077f2e18098 to adfb08â�¦ (flutter/engine#45766) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…lutter#134650) flutter/engine@a8d7d81...5e671d5 2023-09-13 [email protected] Roll devtools from acbc179425b4596b7c2ba7d9c4263077f2e18098 to adfb08â�¦ (flutter/engine#45766) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…c95c626248b28cc60df3b085c12ad8758e
The Dart SDK change https://dart-review.googlesource.com/c/sdk/+/324770 rolled devtools to a newer version. This will be rolled into Flutter engine by the autoroller, but until it is rolled, some triple-headed testing cannot automatically handle this update because it is a CIPD dependency.
This rolls the dependency to the new version to fix the breakage on legacy triple-head testing. This PR is not needed (and will rebase to an empty change) once the Dart SDK is rolled to version 3.2.0-147.0.dev or later