This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Enable private field promotion #45722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform-web
Member
Author
|
Blocked on dart-lang/sdk#53505. |
chinmaygarde
removed
e: impeller
platform-web
chinmaygarde
approved these changes
Sep 12, 2023
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
LGTM after the roll and presubs.
Member
Author
|
Now waiting for dart-lang/sdk@b555e71 to roll in. |
goderbauer
force-pushed
the
privatFields
branch
from
b7eb979 to
ea5d0ce
Compare
github-actions
bot
added
platform-web
goderbauer
force-pushed
the
privatFields
branch
from
ea5d0ce to
48fa2b6
Compare
goderbauer
added
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/45722, due to - The status or check suite Mac mac_clang_tidy_presubmit has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
goderbauer
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 14, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 14, 2023
…134789) flutter/engine@683bca5...45bc430 2023-09-14 [email protected] Enable private field promotion (flutter/engine#45722) 2023-09-14 [email protected] [Impeller] Add Entity::RenderingMode enum. (flutter/engine#45845) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
…lutter#134789) flutter/engine@683bca5...45bc430 2023-09-14 [email protected] Enable private field promotion (flutter/engine#45722) 2023-09-14 [email protected] [Impeller] Add Entity::RenderingMode enum. (flutter/engine#45845) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
New feature in upcoming Dart 3.2. See dart-lang/language#2020. Feature is enabled by bumping the min SDK version to 3.2. Part of flutter/flutter#134476.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature in upcoming Dart 3.2. See dart-lang/language#2020. Feature is enabled by bumping the min SDK version to 3.2.
Part of flutter/flutter#134476.