Pipe VMA asserts to FML. #45661
Pipe VMA asserts to FML. #45661
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Because there is a VMA_HEAVY_ASSERT, there is an argument to be made that the non-heavy variety can be enabled in released modes too. But this patch keeps it simple. |
chinmaygarde
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/45661, due to - The status or check suite Linux linux_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
Oh, the tests were run in opt modes. Failures that were not visible earlier are now being shown 🎉 |
The are still only enabled in unopt modes (we can tweak this later). Assert sometimes may not get piped to the loggers Flutter engine developers usually use. This now brings assertions back in the control of the engine.
chinmaygarde
force-pushed
the
vma_assert
branch
from
cd13d6e to
b216b7a
Compare
chinmaygarde
added
the
autosubmit
…134487) flutter/engine@8389ad9...a983489 2023-09-12 [email protected] Roll libwebp to 1.3.1 (flutter/engine#45675) 2023-09-11 [email protected] Roll Skia from 0b8d2203ab35 to c4e94d5febdc (5 revisions) (flutter/engine#45679) 2023-09-11 [email protected] Pipe VMA asserts to FML. (flutter/engine#45661) 2023-09-11 [email protected] Roll Skia from e6225224fb4e to 0b8d2203ab35 (9 revisions) (flutter/engine#45671) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
These are still only enabled in unopt modes (we can tweak this later). Asserts sometimes may not get piped to the loggers Flutter engine developers usually use. This now brings assertions back in the control of the engine.