This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Adds a GN template that invokes run_tests.py #45595
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
force-pushed
the
gn-run-tests-gni
branch
from
a8dac90 to
0d978ff
Compare
zanderso
added a commit
that referenced
this pull request
Sep 15, 2023
This PR changes run_tests.py to use the python logging library to report results instead of direct prints or writes to stdout/stderr. This change simplifies adding a `--quiet` flag that causes the script to only generate output if a log is emitted at WARNING or above. Overall this is a bit of progress toward landing something like #45595
harryterkelsen
pushed a commit
that referenced
this pull request
Oct 23, 2023
This PR changes run_tests.py to use the python logging library to report results instead of direct prints or writes to stdout/stderr. This change simplifies adding a `--quiet` flag that causes the script to only generate output if a log is emitted at WARNING or above. Overall this is a bit of progress toward landing something like #45595
Member
|
(triage): @zanderso said this is still on his radar when he has time to write code... |
Member
|
(triage): I spoke to @zanderso last week and he said the previous comment is still accurate. |
zanderso
force-pushed
the
gn-run-tests-gni
branch
from
0d978ff to
b224627
Compare
Contributor
|
Could you dump the output of "gn desc" for these new rules somewhere? I'm asking because we will be using "gn desc" to enumerate all build targets and we need some way to identify the targets that use these new templates/rules. |
zanderso
force-pushed
the
gn-run-tests-gni
branch
5 times, most recently
from
2b55104 to
11f8895
Compare
zanderso
force-pushed
the
gn-run-tests-gni
branch
from
11f8895 to
3179e4c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.