This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Restructure Flatland vsync loop #45531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uysalere
force-pushed
the
update-vsync-loop
branch
from
dc03d52 to
54713b2
Compare
arbreng
approved these changes
Sep 7, 2023
|
|
||
| } // namespace | ||
|
|
||
| // This function takes in all relevant information to determining when should |
Contributor
There was a problem hiding this comment.
Nit: Does this comment belong on the constructor or somewhere else?
Contributor
Author
There was a problem hiding this comment.
Ahh leftover comment from an old helper function that is removed now. Erased it.
| threadsafe_state_.on_next_frame_pending_ = true; | ||
| } | ||
| threadsafe_state_.next_presentation_time_ = next_presentation_time; | ||
| // Update vsync_interval_ by calculating. |
Contributor
There was a problem hiding this comment.
Calculating how? For future readers
| } | ||
| threadsafe_state_.next_presentation_time_ = next_presentation_time; | ||
| // Update vsync_interval_ by calculating. | ||
| FML_CHECK(values.has_future_presentation_infos() && |
Contributor
There was a problem hiding this comment.
Should we CHECK here? Is it possible to warn instead and then use an approximation?
Contributor
Author
There was a problem hiding this comment.
Added a warning in case.
| view_protocols = std::move(view_protocols), | ||
| request = parent_viewport_watcher.NewRequest(), | ||
| view_ref_pair = std::move(view_ref_pair), | ||
| max_frames_in_flight = product_config.get_max_frames_in_flight(), |
Contributor
There was a problem hiding this comment.
Nice, I think this means we can get rid of the product config file soon.
Please remove these fields from the flutter_runner_product_config.h
| bool first_feedback_received_ = false; | ||
| FireCallbackCallback pending_fire_callback_; | ||
| uint32_t present_credits_ = 1; | ||
| std::queue<fml::TimePoint> next_presentation_times_; |
Contributor
There was a problem hiding this comment.
Nit: queue first, then other fields, then boolean last (more readable, and fields pack into structure better)
| // Throttle case. | ||
| if (threadsafe_state_.pending_fire_callback_ && | ||
| threadsafe_state_.present_credits_ > 0) { | ||
| RunVsyncCallback(now, threadsafe_state_.pending_fire_callback_); |
Contributor
There was a problem hiding this comment.
Make a note here or below (at the definition of RunVsyncCallback) this is run on the Raster thread, but it is safe b/c the Vsync callback will be posted to the UI thread
Contributor
Author
There was a problem hiding this comment.
Added to the definition of RunVsyncCallback.
uysalere
force-pushed
the
update-vsync-loop
branch
from
54713b2 to
77ea7c2
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 7, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 7, 2023
…134240) flutter/engine@f0b718e...8d07c29 2023-09-07 [email protected] [Impeller] Document and slightly refactor `ResourceManagerVK` & friends. (flutter/engine#45474) 2023-09-07 [email protected] [fuchsia] Restructure Flatland vsync loop (flutter/engine#45531) 2023-09-07 [email protected] Roll Skia from 16df0c27bc0e to c3d6534b0ac3 (3 revisions) (flutter/engine#45543) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
uysalere
added a commit
that referenced
this pull request
Sep 11, 2023
This CL restructures Flatland vsync loop to fire for each vsync instead of each OnNextFrameBegin. As shown in the traces attached to the bug, the current implementation of firing callbacks on each OnNextFrameBegin causes skips when Flutter has longer draw calls. By scheduling frames in between, we are increasing the chance of sending one before the latch point. OnNextFrameBegin is now used to keep track of present credits and future presentation times as well as when to start frame, replacing the need for max_frames_in_flight and vsync_offset fields. Bug: b/296272449 (cherry picked from commit 633ba42)
uysalere
added a commit
to uysalere/engine
that referenced
this pull request
Sep 12, 2023
This CL restructures Flatland vsync loop to fire for each vsync instead of each OnNextFrameBegin. As shown in the traces attached to the bug, the current implementation of firing callbacks on each OnNextFrameBegin causes skips when Flutter has longer draw calls. By scheduling frames in between, we are increasing the chance of sending one before the latch point. OnNextFrameBegin is now used to keep track of present credits and future presentation times as well as when to start frame, replacing the need for max_frames_in_flight and vsync_offset fields. Bug: b/296272449
tarobins
pushed a commit
that referenced
this pull request
Sep 13, 2023
This CL restructures Flatland vsync loop to fire for each vsync instead of each OnNextFrameBegin. As shown in the traces attached to the bug, the current implementation of firing callbacks on each OnNextFrameBegin causes skips when Flutter has longer draw calls. By scheduling frames in between, we are increasing the chance of sending one before the latch point. OnNextFrameBegin is now used to keep track of present credits and future presentation times as well as when to start frame, replacing the need for max_frames_in_flight and vsync_offset fields. Bug: b/296272449 (cherry picked from commit 633ba42)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL restructures Flatland vsync loop to fire for each vsync instead of each OnNextFrameBegin. As shown in the traces attached to the bug, the current implementation of firing callbacks on each OnNextFrameBegin causes skips when Flutter has longer draw calls. By scheduling frames in between, we are increasing the chance of sending one before the latch point. OnNextFrameBegin is now used to keep track of present credits and future presentation times as well as when to start frame, replacing the need for max_frames_in_flight and vsync_offset fields.
Bug: b/296272449