This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Aiks image filters; allow setting effect transforms after FilterContents instantiation. #45530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdero
force-pushed
the
bdero/image-filters
branch
from
226a752 to
46cdb4d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
bdero
changed the title
jonahwilliams
approved these changes
Sep 7, 2023
| virtual void SetEffectTransform(const Matrix& matrix); | ||
|
|
||
| /// @brief Turns on subpass mode for filter inputs. | ||
| virtual void SetIsForSubpass(bool is_for_subpass); |
Contributor
There was a problem hiding this comment.
Nit: can you add more context on what subpass mode implies?
impeller/entity/entity_pass.cc
Outdated
| subpass_texture, | ||
| Matrix::MakeTranslation(Vector3{-global_pass_position}) * | ||
| subpass->xformation_); | ||
| subpass_texture, subpass->xformation_.Basis()); |
Contributor
There was a problem hiding this comment.
Is this a different bug or a new bug?
Member
Author
There was a problem hiding this comment.
Investigating this a bit to remind myself about how we got here. It's kind of peculiar that this was working before.
Member
Author
There was a problem hiding this comment.
I reverted this little change -- it turns out the test was actually behaving correctly and just needed to be adjusted. Before this PR, the effect_transform wasn't being set by the ImageFilter proc defined in the test.
bdero
force-pushed
the
bdero/image-filters
branch
from
e4b2cd7 to
4b876f9
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 8, 2023
…rms after FilterContents instantiation. (flutter/engine#45530)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 8, 2023
…rms after FilterContents instantiation. (flutter/engine#45530)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 8, 2023
…rms after FilterContents instantiation. (flutter/engine#45530)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 8, 2023
…134288) flutter/engine@ea1d0d2...a140ab4 2023-09-08 [email protected] Roll Fuchsia Mac SDK from EuBfOtm5TZIdgNaQe... to h_bQLstuirD8blCZW... (flutter/engine#45571) 2023-09-08 [email protected] Roll ANGLE from 99d39241ad4d to e60556f75b68 (1 revision) (flutter/engine#45569) 2023-09-08 [email protected] [Impeller] Aiks image filters; allow setting effect transforms after FilterContents instantiation. (flutter/engine#45530) 2023-09-08 [email protected] Roll Skia from ce3ec572ae77 to ece9f3a15b08 (1 revision) (flutter/engine#45568) 2023-09-08 [email protected] Roll Skia from fb4faa8646f8 to ce3ec572ae77 (1 revision) (flutter/engine#45567) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from EuBfOtm5TZId to h_bQLstuirD8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are API improvements on the way to solving flutter/flutter#131182.
effect_transformandis_subpassfrom the staticFilterContentsfactories. These are for internal use only.impeller::Paintfilter procs with AiksImageFilterfactories similar toColorFilter. This gives Aiks a simple interface for constructing filters and prevents possible state cloning bugs when copying filters intoEntityPass.EntityPasswithout rendering any snapshots using rect filter inputs.