Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Switch linux_android_debug_engine from goma to reclient #45345

Merged
auto-submit merged 3 commits into from
Sep 14, 2023
Merged

Switch linux_android_debug_engine from goma to reclient #45345

auto-submit merged 3 commits into from
Sep 14, 2023

Conversation

@keyonghan
Copy link
Contributor

@keyonghan keyonghan commented Aug 31, 2023 •
edited
Loading

@keyonghan keyonghan marked this pull request as draft August 31, 2023 20:44
@keyonghan keyonghan changed the title Test rbe Switch linux_android_debug_engine from goma to reclient Sep 13, 2023
@keyonghan keyonghan marked this pull request as ready for review September 13, 2023 15:18
@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 13, 2023

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #45345 at sha 8ded6f6

@keyonghan keyonghan requested a review from zanderso September 13, 2023 22:17
@keyonghan
Copy link
Contributor Author

keyonghan commented Sep 13, 2023

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #45345 at sha 8ded6f6

@zanderso How shall I proceed to resolve these gold images?

@zanderso
Copy link
Member

zanderso commented Sep 13, 2023

I am not seeing any diffs to triage. This looks like it could be a bug in SkiaGold. You might try rebasing the PR.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 14, 2023

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #45345 at sha ccaa969

@keyonghan
Copy link
Contributor Author

keyonghan commented Sep 14, 2023 •
edited
Loading

I am not seeing any diffs to triage. This looks like it could be a bug in SkiaGold. You might try rebasing the PR.

Rebase helps. The PR is ready for review.

The linux_android_debug_engine took 25 mins, which seems comparable with goma, considering roughly different number of cache hits.

chinmaygarde
chinmaygarde approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but perhaps @zanderso should also take a look over it.

@keyonghan keyonghan added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 14, 2023
@auto-submit auto-submit bot merged commit 112342e into flutter:main Sep 14, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 14, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 14, 2023
@engine-flutter-autoroll
112342e6b Switch linux_android_debug_engine from goma to reclient (fl…
c6f81ad 
…utter/engine#45345)
zanderso pushed a commit to flutter/flutter that referenced this pull request Sep 16, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 45bc4307cda3 to 67dd12f8dfca (6 revisions) (#…
18ad09e 
…134791)

flutter/engine@45bc430...67dd12f

2023-09-14 [email protected] Roll Dart SDK from
d25e8d682c8f to 7e4d9f4d8e52 (3 revisions) (flutter/engine#45854)
2023-09-14 [email protected] Remove @pragma('vm:entry-point')
annotations on members that aren't accessed from C++
(flutter/engine#45697)
2023-09-14 [email protected] Roll Skia from 6bc9f5886ddf to
9b7c116ed6c2 (1 revision) (flutter/engine#45853)
2023-09-14 [email protected] Switch
linux_android_debug_engine from goma to reclient (flutter/engine#45345)
2023-09-14 [email protected] Switch goma to
reclient fro standalone targets (flutter/engine#45804)
2023-09-14 [email protected] Handle
external window's `WM_CLOSE` in lifecycle manager (flutter/engine#45840)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll @Mairramer
Roll Flutter Engine from 45bc4307cda3 to 67dd12f8dfca (6 revisions) (f…
ab4afe1 
…lutter#134791)

flutter/engine@45bc430...67dd12f

2023-09-14 [email protected] Roll Dart SDK from
d25e8d682c8f to 7e4d9f4d8e52 (3 revisions) (flutter/engine#45854)
2023-09-14 [email protected] Remove @pragma('vm:entry-point')
annotations on members that aren't accessed from C++
(flutter/engine#45697)
2023-09-14 [email protected] Roll Skia from 6bc9f5886ddf to
9b7c116ed6c2 (1 revision) (flutter/engine#45853)
2023-09-14 [email protected] Switch
linux_android_debug_engine from goma to reclient (flutter/engine#45345)
2023-09-14 [email protected] Switch goma to
reclient fro standalone targets (flutter/engine#45804)
2023-09-14 [email protected] Handle
external window's `WM_CLOSE` in lifecycle manager (flutter/engine#45840)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen pushed a commit that referenced this pull request Oct 23, 2023
@keyonghan @harryterkelsen
Switch linux_android_debug_engine from goma to reclient (#45345)
aba0a3b 
Part of flutter/flutter#132701.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App will affect goldens

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@keyonghan @zanderso @chinmaygarde @kyhannah