This repository was archived by the owner on Feb 25, 2025. It is now read-only.
A minimal engine_tools_lib to use for local-repo Dart tooling
#45154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
reviewed
Aug 28, 2023
Member
zanderso
left a comment
zanderso
left a comment
There was a problem hiding this comment.
I like this idea, but wondering if we shouldn't put this under a new subdirectory like tools/pkg (pkg to mirror subdirectories containing several Dart packages). Also wondering about the name. What do you think of engine_repo_tools?
Contributor
Author
Works for me! Moved and renamed. |
matanlurey
added
the
autosubmit
zanderso
reviewed
Aug 29, 2023
zanderso
approved these changes
Aug 29, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 29, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 29, 2023
…133527) flutter/engine@9778c2c...c7c61ff 2023-08-29 [email protected] Roll Dart SDK from 2900ad211f38 to 60a3bb84fa6d (1 revision) (flutter/engine#45201) 2023-08-29 [email protected] A minimal `engine_tools_lib` to use for local-repo Dart tooling (flutter/engine#45154) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…ter#45154) Partial work towards re-landing flutter#44936. Both the `clang_tidy` and `githooks` passage could benefit from being able to automatically find the latest `compile_commands.json` output, which means that some common code should exist in the `tools/` directory. This is a very minimal (but tested) library for doing exactly that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial work towards re-landing #44936.
Both the
clang_tidyandgithookspassage could benefit from being able to automatically find the latestcompile_commands.jsonoutput, which means that some common code should exist in thetools/directory.This is a very minimal (but tested) library for doing exactly that.