This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "[Impeller] DlAiksCanvas as a DlCanvas wrapper for impeller::Canvas" #45149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Aug 26, 2023
zanderso
added
warning: land on red to fix tree breakage
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 26, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 26, 2023
…133389) flutter/engine@c9b584d...4aaf77e 2023-08-26 [email protected] Revert "[Impeller] DlAiksCanvas as a DlCanvas wrapper for impeller::Canvas" (flutter/engine#45149) 2023-08-26 [email protected] [Impeller] DlAiksCanvas as a DlCanvas wrapper for impeller::Canvas (flutter/engine#45131) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Contributor
|
Without digging too much into it, the platform view code depends heavily on recording DLs and using their RTrees. Is all that functionality provided by impeller::Picture? |
Contributor
|
It is building an RTree,b ut whether the RTree is correct or not is another question. I'll look into this. |
Contributor
|
I'm confused about why this didn't fail on presubmit, but I think it's probably because of some changes that @zanderso made that I might not have sync'd to. I'll double check that. |
Member
Yeah, I recently re-enabled these tests. |
Contributor
|
Ok. There's some sadness fo rme though since they're passing locally. |
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…anvas" (flutter#45149) Reverts flutter#45131 This is failing the Impeller variants of the unobstructed platform views tests: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/132249/overview ``` Failing tests: -[UnobstructedPlatformViewTests testPlatformViewsMaxOverlays] -[UnobstructedPlatformViewTests testOneOverlay] -[UnobstructedPlatformViewTests testOneOverlayPartialIntersection] -[UnobstructedPlatformViewTests testTwoIntersectingOverlays] -[UnobstructedPlatformViewTests testOneOverlayAndTwoIntersectingOverlays] ** TEST FAILED ** ``` We've retried it a few times so I suspect this isn't a flake.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #45131
This is failing the Impeller variants of the unobstructed platform views tests:
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/132249/overview
We've retried it a few times so I suspect this isn't a flake.