This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use runIfNot: ... to avoid running Fuchsia try-jobs for some changes.
#45134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hmm, this is failing @godofredoc @zanderso: |
Contributor
Checking, it seems like I missed updating the proto somewhere. |
1 similar comment
Contributor
Checking, it seems like I missed updating the proto somewhere. |
Contributor
|
Contributor
|
Found the issue for the backend deployment flutter/cocoon#3009 |
Contributor
|
Blocked on flutter/flutter#133376 |
Contributor
|
@matanlurey this is unblocked now. |
Contributor
Author
|
Thank you!!! |
Contributor
Author
zanderso
approved these changes
Aug 29, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 29, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 29, 2023
…133591) flutter/engine@73cc3fb...01a1579 2023-08-29 [email protected] Roll Skia from 15de7f9c3b3b to fb09020ce62d (3 revisions) (flutter/engine#45233) 2023-08-29 [email protected] Use `runIfNot: ...` to avoid running Fuchsia try-jobs for some changes. (flutter/engine#45134) 2023-08-29 [email protected] Clean up engine repo Dart code (flutter/engine#45203) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…s. (flutter#45134) Closes flutter/flutter#93261. I probably could have been more clever with a regular-expression but this seems easier to read. --------- Co-authored-by: godofredoc <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes flutter/flutter#93261.
I probably could have been more clever with a regular-expression but this seems easier to read.