Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Aug 25, 2023

fixes flutter/flutter#133259
Added gradle update instructions and bumped gradle version.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@reidbaker reidbaker requested review from a team and dnfield August 25, 2023 15:51
1. If you have a flutter/engine checkout, then you should already have
[Depot tools](http://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/depot_tools_tutorial.html#_setting_up) on your path.
1. Ensure you have write access for cipd. go/flutter-luci-cipd
1. Download the new version of gradle then Verify the checksum,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Should verify be lowercase here?

@reidbaker reidbaker added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Aug 25, 2023
@auto-submit auto-submit bot merged commit 1471967 into flutter:main Aug 25, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 25, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 25, 2023
gaaclarke pushed a commit to gaaclarke/engine that referenced this pull request Aug 30, 2023
fixes flutter/flutter#133259
Added gradle update instructions and bumped gradle version.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update version of gradle used in the engine

3 participants