This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix building on Pango 1.49.4 #45098
Merged
Fix building on Pango 1.49.4 #45098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
2 tasks
Contributor
|
fails. PangoContext still needs autoptr as of 1.50.14, only PangoLayout got it inside pango. ../../flutter/shell/platform/linux/fl_accessible_text_field.cc:60:3: error: use of undeclared identifier 'glib_autoptr_cleanup_PangoContext'
g_autoptr(PangoContext) context = get_pango_context(self);
^
/usr/include/glib-2.0/glib/gmacros.h:1380:43: note: expanded from macro 'g_autoptr'
#define g_autoptr(TypeName) _GLIB_CLEANUP(_GLIB_AUTOPTR_FUNC_NAME(TypeName)) _GLIB_AUTOPTR_TYPENAME(TypeName)
^
/usr/include/glib-2.0/glib/gmacros.h:1337:43: note: expanded from macro '_GLIB_AUTOPTR_FUNC_NAME'
#define _GLIB_AUTOPTR_FUNC_NAME(TypeName) glib_autoptr_cleanup_##TypeName
^
<scratch space>:84:1: note: expanded from here
glib_autoptr_cleanup_PangoContext
^
../../flutter/shell/platform/linux/fl_accessible_text_field.cc:60:3: error: unknown type name 'PangoContext_autoptr'
/usr/include/glib-2.0/glib/gmacros.h:1380:78: note: expanded from macro 'g_autoptr'
#define g_autoptr(TypeName) _GLIB_CLEANUP(_GLIB_AUTOPTR_FUNC_NAME(TypeName)) _GLIB_AUTOPTR_TYPENAME(TypeName)
^
/usr/include/glib-2.0/glib/gmacros.h:1339:43: note: expanded from macro '_GLIB_AUTOPTR_TYPENAME'
#define _GLIB_AUTOPTR_TYPENAME(TypeName) TypeName##_autoptr
^
<scratch space>:85:1: note: expanded from here
PangoContext_autoptr
^
2 errors generated.
ninja: subcommand failed
|
This version added the autoptr macros which we no longer need to define. flutter/flutter#132881
robert-ancell
force-pushed
the
linux-pango-autoptr-macros
branch
from
bcd29c3 to
41bb032
Compare
Contributor
Author
|
@selfisekai updated, please try again, thanks! |
Contributor
|
@robert-ancell works now |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 4, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 4, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 5, 2023
zanderso
pushed a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 5, 2023
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 5, 2023
…sions) (#134049) Manual roll requested by [email protected] flutter/engine@fbc6f4a...1a6b47a 2023-09-04 [email protected] Roll Dart SDK from 671cf059e4b6 to 43d4b1373788 (2 revisions) (flutter/engine#45435) 2023-09-04 [email protected] Roll Skia from c9d527e6b535 to 8206402f3c35 (1 revision) (flutter/engine#45434) 2023-09-04 [email protected] Fix building on Pango 1.49.4 (flutter/engine#45098) 2023-09-04 [email protected] Roll Dart SDK from a5c7102af509 to 671cf059e4b6 (1 revision) (flutter/engine#45429) 2023-09-04 [email protected] Roll Fuchsia Mac SDK from ynBQWN3XpE2JvSlfd... to A82pOZ3-NNgfJ2Da7... (flutter/engine#45428) 2023-09-04 [email protected] Roll ANGLE from 1fb536394148 to ab9bbb9b11b3 (1 revision) (flutter/engine#45426) 2023-09-04 [email protected] Roll Skia from 5eaf624077b5 to c9d527e6b535 (1 revision) (flutter/engine#45425) 2023-09-04 [email protected] Roll ANGLE from ebf1e7163216 to 1fb536394148 (1 revision) (flutter/engine#45424) 2023-09-04 [email protected] Roll Skia from 906dcd219276 to 5eaf624077b5 (1 revision) (flutter/engine#45423) 2023-09-04 [email protected] Roll Skia from 4d0501380011 to 906dcd219276 (1 revision) (flutter/engine#45422) 2023-09-04 [email protected] Roll Skia from 15f77147a3ec to 4d0501380011 (1 revision) (flutter/engine#45421) 2023-09-04 [email protected] Roll Fuchsia Mac SDK from p56hmQk2lEbN-VwEg... to ynBQWN3XpE2JvSlfd... (flutter/engine#45420) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from p56hmQk2lEbN to A82pOZ3-NNgf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version added the autoptr macros which we no longer need to define.
flutter/flutter#132881