This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Don't place vertex buffer bindings in the Binding map. #45040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
changed the title
chinmaygarde
approved these changes
Aug 24, 2023
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Good call. Metal is the odd one out here.
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 24, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 24, 2023
…133272) flutter/engine@aa98a9d...965501a 2023-08-24 [email protected] Roll Skia from 8b0fd320865e to b17ee34f3378 (1 revision) (flutter/engine#45073) 2023-08-24 [email protected] Revert Dart SDK to 3.2.0-97.0.dev (flutter/engine#45072) 2023-08-24 [email protected] Manual roll Dart SDK from 87a5a26b25fc to bcad589d5d81 (4 revisions) (flutter/engine#45065) 2023-08-24 [email protected] Roll Fuchsia Mac SDK from P8oeVw3whCGS6pCjL... to jkVyhV_xfb8Mv43xj... (flutter/engine#45068) 2023-08-24 [email protected] Roll Skia from e008ee76b890 to 8b0fd320865e (3 revisions) (flutter/engine#45067) 2023-08-24 [email protected] Remove package linter from DEPS (flutter/engine#45053) 2023-08-24 [email protected] Revert "[Impeller] Add debug captures and inspector." (flutter/engine#45062) 2023-08-24 [email protected] [Impeller] Don't place vertex buffer bindings in the Binding map. (flutter/engine#45040) 2023-08-24 [email protected] Roll Skia from 994d5e03fa1c to e008ee76b890 (1 revision) (flutter/engine#45061) 2023-08-24 [email protected] Revert "[Impeller] add trace events for VkRenderPass and VkFrameBuffeâ�¦ (flutter/engine#45047) 2023-08-24 [email protected] Roll Fuchsia Linux SDK from XoUnFqSvX9mhbXqBJ... to 0kEa4JczTMD0Xus08... (flutter/engine#45060) 2023-08-24 [email protected] Roll Skia from 68700a1a2be9 to 994d5e03fa1c (1 revision) (flutter/engine#45059) 2023-08-24 [email protected] Roll Skia from 13a050278b1a to 68700a1a2be9 (1 revision) (flutter/engine#45058) 2023-08-24 [email protected] Roll Skia from 317f4c2ba2ca to 13a050278b1a (1 revision) (flutter/engine#45054) 2023-08-24 [email protected] Roll Skia from 17c0f4b72fcd to 317f4c2ba2ca (1 revision) (flutter/engine#45051) 2023-08-24 [email protected] Roll Skia from 82472773892d to 17c0f4b72fcd (1 revision) (flutter/engine#45050) 2023-08-24 [email protected] Roll Skia from 02eecda395ba to 82472773892d (1 revision) (flutter/engine#45049) 2023-08-24 [email protected] Roll Fuchsia Mac SDK from vJ6oaubpqgRM2nb1e... to P8oeVw3whCGS6pCjL... (flutter/engine#45046) 2023-08-24 [email protected] Roll Fuchsia Linux SDK from -HcyJtxGxUDcqX-jo... to XoUnFqSvX9mhbXqBJ... (flutter/engine#45044) 2023-08-24 [email protected] Manual roll Dart SDK from ab417bc74bb1 to 87a5a26b25fc (4 revisions) (flutter/engine#45043) 2023-08-24 [email protected] [Impeller] Add debug captures and inspector. (flutter/engine#43764) 2023-08-24 [email protected] Roll Skia from e3ee267859a7 to 02eecda395ba (1 revision) (flutter/engine#45042) 2023-08-24 [email protected] Remove a clang-tidy test that launches a full run of clang-tidy (flutter/engine#45033) 2023-08-24 [email protected] Roll Skia from 9d4db3443527 to e3ee267859a7 (1 revision) (flutter/engine#45036) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from -HcyJtxGxUDc to 0kEa4JczTMD0 fuchsia/sdk/core/mac-amd64 from vJ6oaubpqgRM to jkVyhV_xfb8M If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…utter#45040) The metal backend is the only backend that doesn't treat binding the vertex buffer specially. For the GLES and Vulkan backend, we can instead pull it out of the cmd map entirely. This will make it easier to partially inline the map into the bindings object. flutter/flutter#133199
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metal backend is the only backend that doesn't treat binding the vertex buffer specially. For the GLES and Vulkan backend, we can instead pull it out of the cmd map entirely.
This will make it easier to partially inline the map into the bindings object.
flutter/flutter#133199