[Impeller] combine uniform metadata and buffer slots. #45021
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| vertex_bindings.uniforms[slot.ext_res_0] = slot; | ||
| vertex_bindings.buffers[slot.ext_res_0] = BufferResource(metadata, view); |
|
You know, thinking about this I think it might be preferable to go down the assoc vector route instead or in addition of this route. Let's chat you me and Dan. |
|
If you want to refactor that later, thats fine, but we still need to reduce the number of containers. |
jonahwilliams
added
the
autosubmit
…133214) flutter/engine@27d75f6...67e8b82 2023-08-23 [email protected] [Impeller] combine uniform metadata and buffer slots. (flutter/engine#45021) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Follow up from flutter#44990 We're spending a ton of time deallocating mostly empty maps, by reducing the number of maps we reduce the amount of memory used, and reduce map lookups.
2 participants
Follow up from #44990
We're spending a ton of time deallocating mostly empty maps, by reducing the number of maps we reduce the amount of memory used, and reduce map lookups.