This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Document threading configuration with Vulkan. #44874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
impeller/docs/vulkan_threading.md
Outdated
|
|
||
| There is also a separate component called the fence waiter operates on its own | ||
| thread. The sole purpose of this thread is to wait for the GPU to complete | ||
| processing commands so that Impeller can delete the resources when the GPU is |
Contributor
There was a problem hiding this comment.
I would phrase this as something like "The purpose of the fence waiter is to ensure that the resource/ref count lives at least as long as the GPU command buffer(s) that access this resource".
Because of course these fences can fire quite quickly on smaller workloads and finish before the overall frame is finished. Without the resource manager, this would lead to resource deletion as part of the frame workload.
Member
Author
There was a problem hiding this comment.
Done. Copied almost verbatim.
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 20, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 21, 2023
…132918) flutter/engine@2dcfb6c...394554b 2023-08-20 [email protected] [Impeller] Document threading configuration with Vulkan. (flutter/engine#44874) 2023-08-20 [email protected] Roll Fuchsia Mac SDK from onEHyyETXAMieDyfP... to fiGH0e7wu87NiNtTr... (flutter/engine#44875) 2023-08-20 [email protected] Roll Dart SDK from a4908f67b63e to 632c8cccd30c (2 revisions) (flutter/engine#44872) 2023-08-20 [email protected] Roll Fuchsia Linux SDK from pSqQ556xmZp7S4np5... to iQbvLoFBbhU8pkkqw... (flutter/engine#44878) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from pSqQ556xmZp7 to iQbvLoFBbhU8 fuchsia/sdk/core/mac-amd64 from onEHyyETXAMi to fiGH0e7wu87N If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
Moving bits and pieces of the presentation this morning into docs so we can keep them up to date.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving bits and pieces of the presentation this morning into docs so we can keep them up to date.