This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] add trace events for VkRenderPass and VkFrameBuffer creation. #44837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
approved these changes
Aug 18, 2023
jonahwilliams
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/44837, due to - The status or check suite Windows windows_android_aot_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
dnfield
approved these changes
Aug 18, 2023
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 18, 2023
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 18, 2023
…132857) flutter/engine@58f7d8e...83fdada 2023-08-18 [email protected] Update Impeller benchmarks.md with a Pixel 7 link (flutter/engine#44834) 2023-08-18 [email protected] Roll Fuchsia Linux SDK from 7xOzci7fempFgHNk9... to pSqQ556xmZp7S4np5... (flutter/engine#44846) 2023-08-18 [email protected] Roll Dart SDK from 121fcbd8124c to 8109103e041b (1 revision) (flutter/engine#44844) 2023-08-18 [email protected] [Impeller] add trace events for VkRenderPass and VkFrameBuffer creation. (flutter/engine#44837) 2023-08-18 [email protected] Roll Fuchsia Mac SDK from Tnp43n_nAR2N0l_gY... to onEHyyETXAMieDyfP... (flutter/engine#44845) 2023-08-18 [email protected] Roll Skia from 1e62a2d4c429 to c9294edc03b9 (2 revisions) (flutter/engine#44843) 2023-08-18 [email protected] [Android] Expose channel buffer resize and overflow calls (flutter/engine#44434) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 7xOzci7fempF to pSqQ556xmZp7 fuchsia/sdk/core/mac-amd64 from Tnp43n_nAR2N to onEHyyETXAMi If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 24, 2023
#45047) �r creation. (#44837)" This reverts commit ca4ea82. *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue.* These trace events aren't super useful, since we've tracked down the issues as either 1) phone is overloaded due to image decoding at large size or 2) flutter/flutter#133198
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…on. (flutter#44837) To help diagnose flutter/flutter#129392 , which seems to be just as bad on the Pixel 7s: We're not blocking in allocation anymore thanks to our previous allocator clean ups, but something else is blocking. I think it might be one of these methods. 
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
flutter#45047) �r creation. (flutter#44837)" This reverts commit ca4ea82. *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue.* These trace events aren't super useful, since we've tracked down the issues as either 1) phone is overloaded due to image decoding at large size or 2) flutter/flutter#133198
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help diagnose flutter/flutter#129392 , which seems to be just as bad on the Pixel 7s:
We're not blocking in allocation anymore thanks to our previous allocator clean ups, but something else is blocking. I think it might be one of these methods.